[CrOS Tether] Create proto_test_util.cc/h and move CreateTestDeviceStatus() there.

chromeos/components/tether/message_wrapper_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/components/tether/message_wrapper.h"
 
 #include <sstream>
 
 #include "base/base64url.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "chromeos/components/tether/proto/tether.pb.h"
+#include "chromeos/components/tether/proto_test_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 
 namespace tether {
 
 namespace {
 
 DeviceStatus CreateFakeDeviceStatus() {

[Ryan Hansberry, 2017/06/05 22:52:23]

This same method without any args is across about 4 files. Can you please place
it in proto_test_utils as an additional helper method?

[Kyle Horimoto, 2017/06/05 23:18:56]

Done.

-  WifiStatus wifi_status;
-  wifi_status.set_status_code(
-      WifiStatus_StatusCode::WifiStatus_StatusCode_CONNECTED);
-  wifi_status.set_ssid("Google A");
-
-  DeviceStatus device_status;
-  device_status.set_battery_percentage(75);
-  device_status.set_cell_provider("Google Fi");
-  device_status.set_connection_strength(4);
-  device_status.mutable_wifi_status()->CopyFrom(wifi_status);
-
-  return device_status;
+  return CreateTestDeviceStatus("Google Fi", 75 /* battery_percentage */,
+                                4 /* connection_strength */);
 }
 
 TetherAvailabilityResponse CreateTetherAvailabilityResponse() {
   TetherAvailabilityResponse response;
   response.set_response_code(
       TetherAvailabilityResponse_ResponseCode::
           TetherAvailabilityResponse_ResponseCode_TETHER_AVAILABLE);
   response.mutable_device_status()->CopyFrom(CreateFakeDeviceStatus());
   return response;
 }
@@ skipping 152 matching lines @@
   EXPECT_TRUE(wrapper);
   EXPECT_EQ(MessageType::TETHER_AVAILABILITY_RESPONSE,
             wrapper->GetMessageType());
   EXPECT_EQ(response.SerializeAsString(),
             wrapper->GetProto()->SerializeAsString());
 }
 
 }  // namespace tether
 
 }  // namespace cryptauth