Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2925683002: Revert of chromeos: Remove some IME methods from ash::SystemTrayDelegate (Closed)

Created:
3 years, 6 months ago by James Cook
Modified:
3 years, 6 months ago
Reviewers:
Shu Chen, Azure Wei
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank, James Su, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromeos: Remove some IME methods from ash::SystemTrayDelegate (patchset #5 id:80001 of https://codereview.chromium.org/2891263002/ ) Reason for revert: I'm going to take a different approach to the IME methods in the system tray delegate. There's a design doc linked from the bug. Original issue's description: > chromeos: Remove some IME methods from ash::SystemTrayDelegate > > For the mustash project we're trying to eliminate delegates that call > from ash back into chrome browser. > > The IME InputMethodManager interfaces live in //ui/base/ime/chromeos, and > //ash already uses them, so convert some of the system tray code to use > InputMethodManager directly. > > * Remove InputMethodSwitchRecorder and move histogram recording to //ash > * Use InputMethodManager directly in the ash keyboard accelerator code > * Remove ash::ImeControlDelegate and chrome's ImeController. > * Use MockInputMethodManager in all AcceleratorControllerTests > > BUG=724305 > TEST=ash_unittests, manually switch IMEs when running chrome > > Review-Url: https://codereview.chromium.org/2891263002 > Cr-Commit-Position: refs/heads/master@{#474380} > Committed: https://chromium.googlesource.com/chromium/src/+/1290776535cfda1fa1cd7867d5a2ae2ded7e92ec TBR=azurewei@chromium.org,shuchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -175 lines) Patch
M ash/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 12 chunks +33 lines, -47 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 9 chunks +90 lines, -87 lines 0 comments Download
D ash/ime/ime_switch_type.h View 1 chunk +0 lines, -21 lines 0 comments Download
A ash/ime_control_delegate.h View 1 chunk +40 lines, -0 lines 0 comments Download
M ash/system/ime_menu/ime_list_view.cc View 5 chunks +3 lines, -11 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 4 chunks +6 lines, -1 line 0 comments Download
A chrome/browser/chromeos/input_method/input_method_switch_recorder.h View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_switch_recorder.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/ime_controller_chromeos.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/ime_controller_chromeos.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M ui/base/ime/chromeos/mock_input_method_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ime/chromeos/mock_input_method_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Cook
Created Revert of chromeos: Remove some IME methods from ash::SystemTrayDelegate
3 years, 6 months ago (2017-06-05 20:03:39 UTC) #1
James Cook
3 years, 6 months ago (2017-06-05 20:05:52 UTC) #2
On 2017/06/05 20:03:39, James Cook wrote:
> Created Revert of chromeos: Remove some IME methods from
ash::SystemTrayDelegate

Abandoned. I'll revert this by hand because I want to keep parts of the CL.

Powered by Google App Engine
This is Rietveld 408576698