|
chromeos: Remove some IME methods from ash::SystemTrayDelegate
For the mustash project we're trying to eliminate delegates that call
from ash back into chrome browser.
The IME InputMethodManager interfaces live in //ui/base/ime/chromeos, and
//ash already uses them, so convert some of the system tray code to use
InputMethodManager directly.
* Remove InputMethodSwitchRecorder and move histogram recording to //ash
* Use InputMethodManager directly in the ash keyboard accelerator code
* Remove ash::ImeControlDelegate and chrome's ImeController.
* Use MockInputMethodManager in all AcceleratorControllerTests
BUG= 724305
TEST=ash_unittests, manually switch IMEs when running chrome
Review-Url: https://codereview.chromium.org/2891263002
Cr-Commit-Position: refs/heads/master@{#474380}
Committed: https://chromium.googlesource.com/chromium/src/+/1290776535cfda1fa1cd7867d5a2ae2ded7e92ec
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+169 lines, -358 lines) |
Patch |
|
M |
ash/BUILD.gn
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ash/accelerators/accelerator_controller.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
ash/accelerators/accelerator_controller.cc
|
View
|
1
2
3
|
12 chunks |
+45 lines, -31 lines |
0 comments
|
Download
|
|
M |
ash/accelerators/accelerator_controller_unittest.cc
|
View
|
1
2
3
|
9 chunks |
+83 lines, -86 lines |
0 comments
|
Download
|
|
A |
ash/ime/ime_switch_type.h
|
View
|
|
1 chunk |
+21 lines, -0 lines |
0 comments
|
Download
|
|
D |
ash/ime_control_delegate.h
|
View
|
|
1 chunk |
+0 lines, -40 lines |
0 comments
|
Download
|
|
M |
ash/system/ime_menu/ime_list_view.cc
|
View
|
|
5 chunks |
+11 lines, -3 lines |
0 comments
|
Download
|
|
M |
ash/system/tray/system_tray_delegate.h
|
View
|
1
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
ash/system/tray/system_tray_delegate.cc
|
View
|
1
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/BUILD.gn
|
View
|
1
2
3
4
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/input_method/input_method_manager_impl.cc
|
View
|
|
4 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
|
D |
chrome/browser/chromeos/input_method/input_method_switch_recorder.h
|
View
|
|
1 chunk |
+0 lines, -25 lines |
0 comments
|
Download
|
|
D |
chrome/browser/chromeos/input_method/input_method_switch_recorder.cc
|
View
|
|
1 chunk |
+0 lines, -48 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/BUILD.gn
|
View
|
1
2
3
4
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/ash/ash_init.cc
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
D |
chrome/browser/ui/ash/ime_controller_chromeos.h
|
View
|
|
1 chunk |
+0 lines, -30 lines |
0 comments
|
Download
|
|
D |
chrome/browser/ui/ash/ime_controller_chromeos.cc
|
View
|
|
1 chunk |
+0 lines, -50 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/ash/system_tray_delegate_chromeos.h
|
View
|
1
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
|
View
|
1
|
2 chunks |
+0 lines, -13 lines |
0 comments
|
Download
|
|
M |
ui/base/ime/chromeos/mock_input_method_manager.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
ui/base/ime/chromeos/mock_input_method_manager.cc
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
Total messages: 36 (22 generated)
|