chromeos: Remove some IME methods from ash::SystemTrayDelegate

chromeos: Remove some IME methods from ash::SystemTrayDelegate

For the mustash project we're trying to eliminate delegates that call
from ash back into chrome browser.

The IME InputMethodManager interfaces live in //ui/base/ime/chromeos, and
//ash already uses them, so convert some of the system tray code to use
InputMethodManager directly.

* Remove InputMethodSwitchRecorder and move histogram recording to //ash
* Use InputMethodManager directly in the ash keyboard accelerator code
* Remove ash::ImeControlDelegate and chrome's ImeController.
* Use MockInputMethodManager in all AcceleratorControllerTests

BUG=724305
TEST=ash_unittests, manually switch IMEs when running chrome

Review-Url: https://codereview.chromium.org/2891263002
Cr-Commit-Position: refs/heads/master@{#474380}
Committed: https://chromium.googlesource.com/chromium/src/+/1290776535cfda1fa1cd7867d5a2ae2ded7e92ec

[James Cook, 2017-05-19 02:35:25]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 02:36:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:39:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 02:40:00]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[James Cook, 2017-05-19 04:19:49]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 04:20:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 07:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 07:18:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[James Cook, 2017-05-22 23:53:45]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 23:54:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-23 00:01:43]

jamescook@chromium.org changed reviewers:
+ azurewei@chromium.org

[James Cook, 2017-05-23 00:01:44]

azurewei, please take a look.

https://codereview.chromium.org/2891263002/diff/60001/ui/base/ime/chromeos/mo...
File ui/base/ime/chromeos/mock_input_method_manager.h (right):

https://codereview.chromium.org/2891263002/diff/60001/ui/base/ime/chromeos/mo...
ui/base/ime/chromeos/mock_input_method_manager.h:24:
scoped_refptr<InputMethodManager::State> Clone() const override;
I'm not using Clone(). This method has to exist so I can make my own
MockInputMethodManager::State subclass for the AcceleratorController test. (My
test seems to be first user of MockInputMethodManager::State.)

[commit-bot: I haz the power, 2017-05-23 01:14:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 01:14:17]

Dry run: This issue passed the CQ dry run.

[Azure Wei, 2017-05-23 07:36:59]

lgtm

[James Cook, 2017-05-23 15:34:24]

jamescook@chromium.org changed reviewers:
+ shuchen@chromium.org

[James Cook, 2017-05-23 15:34:24]

shuchen, can I get OWNERS for chrome/browser/chromeos/input_method and
ui/base/ime/chromeos?

[Shu Chen, 2017-05-24 04:29:19]

On 2017/05/23 15:34:24, James Cook wrote:
> shuchen, can I get OWNERS for chrome/browser/chromeos/input_method and
> ui/base/ime/chromeos?

Sure. Please put yourself as the OWNERS.

[Shu Chen, 2017-05-24 04:29:26]

lgtm

[James Cook, 2017-05-24 08:07:51]

Thanks for the review. I don't want to be in the OWNERS file, I just needed you
to review it as an owner.

[James Cook, 2017-05-24 08:08:00]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-05-24 08:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
shuchen@chromium.org, azurewei@chromium.org
Link to the patchset: https://codereview.chromium.org/2891263002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-24 08:08:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 09:14:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 09:14:13]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[James Cook, 2017-05-24 15:20:28]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-05-24 15:21:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 17:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 17:36:07]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[James Cook, 2017-05-24 17:39:59]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-05-24 17:40:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:07:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495647599299070,
"parent_rev": "526c7ebbc8501df55df5ecb0ee90e08368ee6852", "commit_rev":
"1290776535cfda1fa1cd7867d5a2ae2ded7e92ec"}

[commit-bot: I haz the power, 2017-05-24 19:07:23]

Description was changed from

==========
chromeos: Remove some IME methods from ash::SystemTrayDelegate

For the mustash project we're trying to eliminate delegates that call
from ash back into chrome browser.

The IME InputMethodManager interfaces live in //ui/base/ime/chromeos, and
//ash already uses them, so convert some of the system tray code to use
InputMethodManager directly.

* Remove InputMethodSwitchRecorder and move histogram recording to //ash
* Use InputMethodManager directly in the ash keyboard accelerator code
* Remove ash::ImeControlDelegate and chrome's ImeController.
* Use MockInputMethodManager in all AcceleratorControllerTests

BUG=724305
TEST=ash_unittests, manually switch IMEs when running chrome
==========

to

==========
chromeos: Remove some IME methods from ash::SystemTrayDelegate

For the mustash project we're trying to eliminate delegates that call
from ash back into chrome browser.

The IME InputMethodManager interfaces live in //ui/base/ime/chromeos, and
//ash already uses them, so convert some of the system tray code to use
InputMethodManager directly.

* Remove InputMethodSwitchRecorder and move histogram recording to //ash
* Use InputMethodManager directly in the ash keyboard accelerator code
* Remove ash::ImeControlDelegate and chrome's ImeController.
* Use MockInputMethodManager in all AcceleratorControllerTests

BUG=724305
TEST=ash_unittests, manually switch IMEs when running chrome

Review-Url: https://codereview.chromium.org/2891263002
Cr-Commit-Position: refs/heads/master@{#474380}
Committed:
https://chromium.googlesource.com/chromium/src/+/1290776535cfda1fa1cd7867d5a2...
==========

[commit-bot: I haz the power, 2017-05-24 19:07:25]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1290776535cfda1fa1cd7867d5a2...

[James Cook, 2017-06-05 20:03:38]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2925683002/ by jamescook@chromium.org.

The reason for reverting is: I'm going to take a different approach to the IME
methods in the system tray delegate. There's a design doc linked from the bug.
.

[James Cook, 2017-06-05 20:06:21]

On 2017/06/05 20:03:38, James Cook wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/2925683002/ by mailto:jamescook@chromium.org.
> 
> The reason for reverting is: I'm going to take a different approach to the IME
> methods in the system tray delegate. There's a design doc linked from the bug.
> .

I didn't use the revert CL. I'll revert this by hand because I want to keep
parts of the CL.