Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.

Created:
3 years, 6 months ago by Łukasz Anforowicz
Modified:
3 years, 6 months ago
Reviewers:
bcwhite
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

UMA recording the kind of target frame when extensions pierce browsing instance. Extensions violate browsing instance boundaries. The UMA metrics added in this CL should help confirm or deny the theory that violating browsing instance boundaries is only needed for looking up background contents / pages (of VIEW_TYPE_BACKGROUND_CONTENTS type). BUG=718489

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -34 lines) Patch
M base/test/histogram_tester.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_functional_browsertest.cc View 1 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/sync_helper.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/common/features/simple_feature.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/manifest.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M extensions/common/view_type.h View 1 chunk +19 lines, -12 lines 0 comments Download
M extensions/renderer/extension_frame_helper.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/extension_frame_helper.cc View 1 2 chunks +19 lines, -2 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (10 generated)
Łukasz Anforowicz
bcwhite@, could you please help me with one aspect of this WIP CL? I am ...
3 years, 6 months ago (2017-06-07 23:24:36 UTC) #2
bcwhite
> bcwhite@, could you please help me with one aspect of this WIP CL? I ...
3 years, 6 months ago (2017-06-08 13:01:11 UTC) #3
Łukasz Anforowicz
3 years, 6 months ago (2017-06-08 16:27:56 UTC) #7
On 2017/06/08 13:01:11, bcwhite wrote:
> > bcwhite@, could you please help me with one aspect of this WIP CL?  I am
> trying
> > to use base::HistogramTester from a browser test and failing - the UMA I
want
> to
> > test is recorded from a renderer and apparently the histogram tester (in the
> > browser-side of a browser test) doesn't see the recorded data... :-/
> 
> Call SubprocessMetricsProvider::MergeHistogramDeltasForTesting() in your test
to
> import those values.  No need for the Renderer to exit.

Excellent - this works great.  Thank you for your help!

In the latest patchset I've tried adding a comment to
base/test/histogram_tester.h that mentions
SubprocessMetricsProvider::MergeHistogramDeltasForTesting().  I hope this looks
good (I was wondering whether it in some way violates layering"by referring to
//chrome functions from a //base comment, but in the end I think that it is
better to have too much rather than too little documentation and hints in the
code).

Powered by Google App Engine
This is Rietveld 408576698