chrome/browser/extensions/extension_management.cc - Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management.cc

Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.

Patch Set: Rebasing... Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_management.cc

diff --git a/chrome/browser/extensions/extension_management.cc b/chrome/browser/extensions/extension_management.cc

index 8427cafde7c7614cde801244d2c6b2d47c3f4c69..a2209206476fa9e8b3c8aa8be08ebffb4cd5d3e7 100644

--- a/chrome/browser/extensions/extension_management.cc

+++ b/chrome/browser/extensions/extension_management.cc

@@ -387,7 +387,7 @@ void ExtensionManagement::Refresh() {

int int_value;

std::string string_value;

if (it->GetAsInteger(&int_value) && int_value >= 0 &&

- int_value < Manifest::Type::NUM_LOAD_TYPES) {

+ int_value <= Manifest::Type::TYPE_MAX) {

global_settings_->allowed_types.push_back(

static_cast<Manifest::Type>(int_value));

} else if (it->GetAsString(&string_value)) {