Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Side by Side Diff: chrome/browser/extensions/standard_management_policy_provider.cc

Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.
Patch Set: Rebasing... Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | chrome/common/extensions/sync_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/standard_management_policy_provider.h" 5 #include "chrome/browser/extensions/standard_management_policy_provider.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 case Manifest::TYPE_THEME: 93 case Manifest::TYPE_THEME:
94 case Manifest::TYPE_USER_SCRIPT: 94 case Manifest::TYPE_USER_SCRIPT:
95 case Manifest::TYPE_HOSTED_APP: 95 case Manifest::TYPE_HOSTED_APP:
96 case Manifest::TYPE_LEGACY_PACKAGED_APP: 96 case Manifest::TYPE_LEGACY_PACKAGED_APP:
97 case Manifest::TYPE_PLATFORM_APP: 97 case Manifest::TYPE_PLATFORM_APP:
98 case Manifest::TYPE_SHARED_MODULE: { 98 case Manifest::TYPE_SHARED_MODULE: {
99 if (!settings_->IsAllowedManifestType(extension->GetType())) 99 if (!settings_->IsAllowedManifestType(extension->GetType()))
100 return ReturnLoadError(extension, error); 100 return ReturnLoadError(extension, error);
101 break; 101 break;
102 } 102 }
103 case Manifest::NUM_LOAD_TYPES:
104 NOTREACHED();
105 } 103 }
106 104
107 if (installation_mode == ExtensionManagement::INSTALLATION_BLOCKED) 105 if (installation_mode == ExtensionManagement::INSTALLATION_BLOCKED)
108 return ReturnLoadError(extension, error); 106 return ReturnLoadError(extension, error);
109 107
110 return true; 108 return true;
111 } 109 }
112 110
113 bool StandardManagementPolicyProvider::UserMayModifySettings( 111 bool StandardManagementPolicyProvider::UserMayModifySettings(
114 const Extension* extension, 112 const Extension* extension,
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 *error = l10n_util::GetStringFUTF16( 166 *error = l10n_util::GetStringFUTF16(
169 IDS_EXTENSION_CANT_INSTALL_POLICY_BLOCKED, 167 IDS_EXTENSION_CANT_INSTALL_POLICY_BLOCKED,
170 base::UTF8ToUTF16(extension->name()), 168 base::UTF8ToUTF16(extension->name()),
171 base::UTF8ToUTF16(extension->id()), 169 base::UTF8ToUTF16(extension->id()),
172 base::UTF8ToUTF16(settings_->BlockedInstallMessage(extension->id()))); 170 base::UTF8ToUTF16(settings_->BlockedInstallMessage(extension->id())));
173 } 171 }
174 return false; 172 return false;
175 } 173 }
176 174
177 } // namespace extensions 175 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | chrome/common/extensions/sync_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698