Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: extensions/common/view_type.h

Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.
Patch Set: Rebasing... Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest.h ('k') | extensions/renderer/extension_frame_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/view_type.h
diff --git a/extensions/common/view_type.h b/extensions/common/view_type.h
index 5fc7c2731943675dfab3623d8fedcf041be164c3..2d54b180cab76406c549a97af33cde4b817fc802 100644
--- a/extensions/common/view_type.h
+++ b/extensions/common/view_type.h
@@ -10,21 +10,28 @@ namespace extensions {
// Icky RTTI used by a few systems to distinguish the host type of a given
// WebContents.
//
+// Do not change the order of entries or remove entries in this list as this
+// is used in ExtensionViewType enum in tools/metrics/histograms/enums.xml.
+//
// TODO(aa): Remove this and teach those systems to keep track of their own
// data.
enum ViewType {
- VIEW_TYPE_INVALID,
- VIEW_TYPE_APP_WINDOW,
- VIEW_TYPE_BACKGROUND_CONTENTS,
- VIEW_TYPE_COMPONENT, // For custom parts of Chrome if no other type applies.
- VIEW_TYPE_EXTENSION_BACKGROUND_PAGE,
- VIEW_TYPE_EXTENSION_DIALOG,
- VIEW_TYPE_EXTENSION_GUEST,
- VIEW_TYPE_EXTENSION_POPUP,
- VIEW_TYPE_LAUNCHER_PAGE,
- VIEW_TYPE_PANEL,
- VIEW_TYPE_TAB_CONTENTS,
- VIEW_TYPE_LAST = VIEW_TYPE_TAB_CONTENTS
+ VIEW_TYPE_INVALID = 0,
+ VIEW_TYPE_APP_WINDOW = 1,
+ VIEW_TYPE_BACKGROUND_CONTENTS = 2,
+
+ // For custom parts of Chrome if no other type applies.
+ VIEW_TYPE_COMPONENT = 3,
+
+ VIEW_TYPE_EXTENSION_BACKGROUND_PAGE = 4,
+ VIEW_TYPE_EXTENSION_DIALOG = 5,
+ VIEW_TYPE_EXTENSION_GUEST = 6,
+ VIEW_TYPE_EXTENSION_POPUP = 7,
+ VIEW_TYPE_LAUNCHER_PAGE = 8,
+ VIEW_TYPE_PANEL = 9,
+ VIEW_TYPE_TAB_CONTENTS = 10,
+
+ VIEW_TYPE_LAST = VIEW_TYPE_TAB_CONTENTS,
};
// Constant strings corresponding to the Type enumeration values. Used
« no previous file with comments | « extensions/common/manifest.h ('k') | extensions/renderer/extension_frame_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698