Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: ui/views/touchui/touch_selection_controller_impl.cc

Issue 2924893002: touch ui: Do not hide text selection handles when screen is rotated. (Closed)
Patch Set: Compiles. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/touchui/touch_selection_controller_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/touchui/touch_selection_controller_impl.cc
diff --git a/ui/views/touchui/touch_selection_controller_impl.cc b/ui/views/touchui/touch_selection_controller_impl.cc
index 059709030799446c35d54c78b73330da7e71bab3..0846f6a0c50cf6b2a162e325248ffcb0c5dc74f1 100644
--- a/ui/views/touchui/touch_selection_controller_impl.cc
+++ b/ui/views/touchui/touch_selection_controller_impl.cc
@@ -446,7 +446,6 @@ TouchSelectionControllerImpl::TouchSelectionControllerImpl(
dragging_handle_(nullptr) {
selection_start_time_ = base::TimeTicks::Now();
aura::Window* client_window = client_view_->GetNativeView();
- client_window->AddObserver(this);
client_widget_ = Widget::GetTopLevelWidgetForNativeView(client_window);
if (client_widget_)
client_widget_->AddObserver(this);
@@ -460,7 +459,6 @@ TouchSelectionControllerImpl::~TouchSelectionControllerImpl() {
aura::Env::GetInstance()->RemovePreTargetHandler(this);
if (client_widget_)
client_widget_->RemoveObserver(this);
- client_view_->GetNativeView()->RemoveObserver(this);
}
void TouchSelectionControllerImpl::SelectionChanged() {
@@ -643,12 +641,6 @@ void TouchSelectionControllerImpl::RunContextMenu() {
client_view_->OpenContextMenu(anchor);
}
-void TouchSelectionControllerImpl::OnAncestorWindowTransformed(
- aura::Window* window,
- aura::Window* ancestor) {
- client_view_->DestroyTouchSelection();
-}
-
void TouchSelectionControllerImpl::OnWidgetClosing(Widget* widget) {
DCHECK_EQ(client_widget_, widget);
client_widget_->RemoveObserver(this);
« no previous file with comments | « ui/views/touchui/touch_selection_controller_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698