Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2924873004: DevTools: migrate MetricsSidebarPane to shadow (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate MetricsSidebarPane to shadow BUG=726972 Review-Url: https://codereview.chromium.org/2924873004 Cr-Commit-Position: refs/heads/master@{#477880} Committed: https://chromium.googlesource.com/chromium/src/+/1723af89f9dca5b35dc342ccdf36970fc49b548b

Patch Set 1 : fix border #

Total comments: 3

Patch Set 2 : rebase #

Messages

Total messages: 10 (6 generated)
luoe
Please take a look. This patch doesn't really depend on the last CL, but I've ...
3 years, 6 months ago (2017-06-06 21:25:49 UTC) #4
dgozman
lgtm
3 years, 6 months ago (2017-06-07 22:06:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924873004/60001
3 years, 6 months ago (2017-06-08 00:58:24 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 04:08:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1723af89f9dca5b35dc342ccdf36...

Powered by Google App Engine
This is Rietveld 408576698