DevTools: move styles sidebar toolbar into StylesSidebarPane

DevTools: move styles sidebar toolbar into StylesSidebarPane

This is part of an effort to migrate SSP to shadow DOM as its own component.

BUG=726972
Review-Url: https://codereview.chromium.org/2917033004
Cr-Commit-Position: refs/heads/master@{#477478}
Committed: https://chromium.googlesource.com/chromium/src/+/1406904015cba22c1af48fff00043f44accc4f94

[luoe, 2017-06-02 21:41:44]

Patchset #1 (id:1) has been deleted

[luoe, 2017-06-02 21:42:52]

Description was changed from

==========
DevTools: move toolbar into StylesSidebarPane

BUG=726972
==========

to

==========
DevTools: move styles sidebar toolbar into StylesSidebarPane

This is part of an effort to migrate SSP to shadow DOM as its own component.

BUG=726972
==========

[luoe, 2017-06-02 21:43:55]

luoe@chromium.org changed reviewers:
+ einbinder@chromium.org

[luoe, 2017-06-02 21:43:55]

Please take a look

https://codereview.chromium.org/2917033004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2917033004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:548:
return toolbarPaneContent;
tldr: `_toolbarPaneElement` refers to the same thing as before, but this
function has a different return value.

This function used to return the container, but in this CL returns the content
insertion point.  We don't need to save the container anymore if it's always
inside the SSP styles widget.

[einbinder, 2017-06-03 01:50:58]

I want to look it over again in a few hours before I give l g t m. StylesSidebar
makes my head hurt.

https://codereview.chromium.org/2917033004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2917033004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:572:
_startToolbarPaneAnimation(widget) {
This seems like a lot of work for 60 frames of animation. We don't use animation
in other similar places, like settings gear in console. Maybe this should just
go away?

[luoe, 2017-06-05 19:03:36]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org

[luoe, 2017-06-05 19:03:37]

Rebased on the dependent CL.  Please take a look

https://codereview.chromium.org/2917033004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2917033004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:572:
_startToolbarPaneAnimation(widget) {
On 2017/06/03 01:50:57, einbinder wrote:
> This seems like a lot of work for 60 frames of animation. We don't use
animation
> in other similar places, like settings gear in console. Maybe this should just
> go away?

That sounds like a good idea, I can tackle it separately.  Another place with
similar functionality is the 'Pause on caught exceptions' slide in.  For this
CL, I'd rather just leave it as is and not touch it, though.

[dgozman, 2017-06-05 21:07:23]

https://codereview.chromium.org/2917033004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
(right):

https://codereview.chromium.org/2917033004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:122:
showToolbarPane(widget, toggle) {
Why this method is still here?

[luoe, 2017-06-05 21:31:30]

https://codereview.chromium.org/2917033004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
(right):

https://codereview.chromium.org/2917033004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:122:
showToolbarPane(widget, toggle) {
On 2017/06/05 21:07:23, dgozman wrote:
> Why this method is still here?

It's still used by some providers:
-
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...
-
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...

Maybe Classes/ElementStatePaneWidget shouldn't be extensions, or we should have
a way to specify ToolbarPaneRadioButtons?

[dgozman, 2017-06-06 21:43:06]

lgtm

https://codereview.chromium.org/2917033004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
(right):

https://codereview.chromium.org/2917033004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:122:
showToolbarPane(widget, toggle) {
On 2017/06/05 21:31:30, luoe wrote:
> On 2017/06/05 21:07:23, dgozman wrote:
> > Why this method is still here?
> 
> It's still used by some providers:
> -
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...
> -
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...
> 
> Maybe Classes/ElementStatePaneWidget shouldn't be extensions, or we should
have
> a way to specify ToolbarPaneRadioButtons?

Let's add a TODO to remove this.

[luoe, 2017-06-06 22:00:01]

https://codereview.chromium.org/2917033004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
(right):

https://codereview.chromium.org/2917033004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:122:
showToolbarPane(widget, toggle) {
On 2017/06/06 21:43:06, dgozman wrote:
> On 2017/06/05 21:31:30, luoe wrote:
> > On 2017/06/05 21:07:23, dgozman wrote:
> > > Why this method is still here?
> > 
> > It's still used by some providers:
> > -
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...
> > -
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...
> > 
> > Maybe Classes/ElementStatePaneWidget shouldn't be extensions, or we should
> have
> > a way to specify ToolbarPaneRadioButtons?
> 
> Let's add a TODO to remove this.

Done.

[luoe, 2017-06-06 22:00:06]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-06-06 22:00:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2917033004/#ps60001
(title: "rebase and ac")

[commit-bot: I haz the power, 2017-06-06 22:00:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 00:17:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496786406877540,
"parent_rev": "a27564e55ec5fd0ff168c23d927c68dec145871c", "commit_rev":
"1406904015cba22c1af48fff00043f44accc4f94"}

[commit-bot: I haz the power, 2017-06-07 00:17:20]

Description was changed from

==========
DevTools: move styles sidebar toolbar into StylesSidebarPane

This is part of an effort to migrate SSP to shadow DOM as its own component.

BUG=726972
==========

to

==========
DevTools: move styles sidebar toolbar into StylesSidebarPane

This is part of an effort to migrate SSP to shadow DOM as its own component.

BUG=726972

Review-Url: https://codereview.chromium.org/2917033004
Cr-Commit-Position: refs/heads/master@{#477478}
Committed:
https://chromium.googlesource.com/chromium/src/+/1406904015cba22c1af48fff0004...
==========

[commit-bot: I haz the power, 2017-06-07 00:17:23]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1406904015cba22c1af48fff0004...