Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2924633002: Remove unused IdeOptions (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : reverse default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -197 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 8 chunks +25 lines, -32 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +1 line, -6 lines 0 comments Download
D pkg/analysis_server/lib/src/ide_options.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion_core.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_core.dart View 3 chunks +1 line, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 4 chunks +2 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/field_formal_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 3 chunks +8 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/library_prefix_contributor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart View 6 chunks +8 lines, -15 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart View 4 chunks +3 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart View 9 chunks +11 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 7 chunks +7 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/utilities.dart View 1 3 chunks +1 line, -23 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I assumed that the appropriate default value for the option was `true`.
3 years, 6 months ago (2017-06-05 18:25:40 UTC) #2
pquitslund
LGTM. Thanks!
3 years, 6 months ago (2017-06-05 21:06:23 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-05 21:12:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
dc972240d4e5bd16ce40ec0339839bb7b4c22e98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698