Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

Issue 2924633002: Remove unused IdeOptions (Closed)
Patch Set: reverse default Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
index b9cdacdb64fece43097aee4a89da97d58031e61b..9a37d1b2faefdea1989ee1d294c6a9abac235a68 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
@@ -46,8 +46,7 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
int relevance = optype.typeNameSuggestionsFilter(
element.type, DART_RELEVANCE_DEFAULT);
if (relevance != null) {
- addSuggestion(element, request.ideOptions,
- prefix: prefix, relevance: relevance);
+ addSuggestion(element, prefix: prefix, relevance: relevance);
}
}
if (optype.includeConstructorSuggestions) {
@@ -84,13 +83,11 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
DartType returnType = element.returnType;
if (returnType != null && returnType.isVoid) {
if (optype.includeVoidReturnSuggestions) {
- addSuggestion(element, request.ideOptions,
- prefix: prefix, relevance: relevance);
+ addSuggestion(element, prefix: prefix, relevance: relevance);
}
} else {
if (optype.includeReturnValueSuggestions) {
- addSuggestion(element, request.ideOptions,
- prefix: prefix, relevance: relevance);
+ addSuggestion(element, prefix: prefix, relevance: relevance);
}
}
}
@@ -101,8 +98,7 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
int relevance = element.library == containingLibrary
? DART_RELEVANCE_LOCAL_FUNCTION
: DART_RELEVANCE_DEFAULT;
- addSuggestion(element, request.ideOptions,
- prefix: prefix, relevance: relevance);
+ addSuggestion(element, prefix: prefix, relevance: relevance);
}
}
@@ -124,8 +120,7 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
} else {
relevance = DART_RELEVANCE_DEFAULT;
}
- addSuggestion(element, request.ideOptions,
- prefix: prefix, relevance: relevance);
+ addSuggestion(element, prefix: prefix, relevance: relevance);
}
}
@@ -135,8 +130,7 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
int relevance = element.library == containingLibrary
? DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE
: DART_RELEVANCE_DEFAULT;
- addSuggestion(element, request.ideOptions,
- prefix: prefix, relevance: relevance);
+ addSuggestion(element, prefix: prefix, relevance: relevance);
}
}
@@ -147,9 +141,8 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
String className = classElem.name;
for (ConstructorElement constructor in classElem.constructors) {
if (!constructor.isPrivate) {
- CompletionSuggestion suggestion = createSuggestion(
- constructor, request.ideOptions,
- relevance: relevance);
+ CompletionSuggestion suggestion =
+ createSuggestion(constructor, relevance: relevance);
if (suggestion != null) {
String name = suggestion.completion;
name = name.length > 0 ? '$className.$name' : className;

Powered by Google App Engine
This is Rietveld 408576698