Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/utilities.dart

Issue 2924633002: Remove unused IdeOptions (Closed)
Patch Set: reverse default Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/utilities.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart b/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart
index 6df8fc1481d37fa43c9c77637e1b2475691bbf81..baf199e6cd3d2dc36d2ec01b292c9a8b8fa8072c 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart
@@ -5,11 +5,9 @@
/**
* A collection of utility methods used by completion contributors.
*/
-import 'package:analysis_server/src/ide_options.dart';
import 'package:analysis_server/src/protocol_server.dart'
show CompletionSuggestion, CompletionSuggestionKind, Location;
import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';
-import 'package:analysis_server/src/services/correction/flutter_util.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/standard_ast_factory.dart';
import 'package:analyzer/dart/ast/token.dart';
@@ -40,8 +38,7 @@ void addDefaultArgDetails(
CompletionSuggestion suggestion,
Element element,
Iterable<ParameterElement> requiredParams,
- Iterable<ParameterElement> namedParams,
- IdeOptions options) {
+ Iterable<ParameterElement> namedParams) {
StringBuffer sb = new StringBuffer();
List<int> ranges = <int>[];
@@ -71,25 +68,6 @@ void addDefaultArgDetails(
}
}
- if (options?.generateFlutterWidgetChildrenBoilerPlate == true) {
- if (element is ConstructorElement) {
- if (isFlutterWidget(element.enclosingElement)) {
- for (ParameterElement param in element.parameters) {
- if (param.name == 'children') {
- String defaultValue = getDefaultStringParameterValue(param) ?? '';
- if (sb.isNotEmpty) {
- sb.write(', ');
- }
- sb.write('children: ');
- offset = sb.length;
- sb.write(defaultValue);
- ranges.addAll([offset, defaultValue.length]);
- }
- }
- }
- }
- }
-
suggestion.defaultArgumentListString = sb.isNotEmpty ? sb.toString() : null;
suggestion.defaultArgumentListTextRanges = ranges.isNotEmpty ? ranges : null;
}

Powered by Google App Engine
This is Rietveld 408576698