Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart

Issue 2924633002: Remove unused IdeOptions (Closed)
Patch Set: reverse default Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart
index 0271ab7246c11355b7cf19a3167c28ff3e934232..5874ac516482ad8271e2dbc00aa6e6281ac19ce4 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart
@@ -4,7 +4,6 @@
import 'dart:async';
-import 'package:analysis_server/src/ide_options.dart';
import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';
import 'package:analysis_server/src/services/completion/dart/suggestion_builder.dart';
import 'package:analyzer/dart/ast/ast.dart';
@@ -34,7 +33,7 @@ class NamedConstructorContributor extends DartCompletionContributor {
if (type != null) {
Element classElem = type.element;
if (classElem is ClassElement) {
- return _buildSuggestions(libElem, classElem, request.ideOptions);
+ return _buildSuggestions(libElem, classElem);
}
}
}
@@ -43,15 +42,14 @@ class NamedConstructorContributor extends DartCompletionContributor {
}
List<CompletionSuggestion> _buildSuggestions(
- LibraryElement libElem, ClassElement classElem, IdeOptions options) {
+ LibraryElement libElem, ClassElement classElem) {
bool isLocalClassDecl = classElem.library == libElem;
List<CompletionSuggestion> suggestions = <CompletionSuggestion>[];
for (ConstructorElement elem in classElem.constructors) {
if (isLocalClassDecl || !elem.isPrivate) {
String name = elem.name;
if (name != null) {
- CompletionSuggestion s =
- createSuggestion(elem, options, completion: name);
+ CompletionSuggestion s = createSuggestion(elem, completion: name);
if (s != null) {
suggestions.add(s);
}

Powered by Google App Engine
This is Rietveld 408576698