Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2924343002: Move ui::GetAtom to gfx::GetAtom (Closed)

Created:
3 years, 6 months ago by Tom Anderson
Modified:
3 years, 6 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, chfremer+watch_chromium.org, dcheng, feature-media-reviews_chromium.org, oshima+watch_chromium.org, tfarina, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ui::GetAtom to gfx::GetAtom This CL is a followup to [1]. However, unlike that CL, this one should have no functional changes as it is purely a refactoring. This CL adds gfx::GetAtom (and renames the ::ui namespace in x11_atom_cache to ::gfx) and updates all references that used to point to ui::GetAtom to gfx::GetAtom. Also update PRESUBMIT.py to include exceptions for 2 files that use XInternAtom appropriately. [1] https://codereview.chromium.org/2914103002/ BUG=730889 R=sadrul@chromium.org TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2924343002 Cr-Commit-Position: refs/heads/master@{#478103} Committed: https://chromium.googlesource.com/chromium/src/+/11aa41dc3c2e265a712b55d0a642739493ac78eb

Patch Set 1 #

Patch Set 2 : fix CrOs build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -270 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc/window_icon_util_x11.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/test/ui_controls_factory_aurax11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 11 chunks +12 lines, -11 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 24 chunks +35 lines, -34 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/idle/screensaver_window_finder_x11.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/base/x/selection_owner.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M ui/base/x/selection_requestor.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/base/x/selection_requestor_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M ui/base/x/selection_utils.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M ui/base/x/x11_menu_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/x/x11_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/x/x11_util.cc View 11 chunks +20 lines, -27 lines 0 comments Download
M ui/display/manager/chromeos/x11/native_display_delegate_x11.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M ui/display/util/x11/edid_parser_x11.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/events/platform/x11/x11_event_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M ui/gfx/icc_profile_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/x/x11_atom_cache.h View 3 chunks +9 lines, -5 lines 0 comments Download
M ui/gfx/x/x11_atom_cache.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/platform_window/x11/x11_window_base.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/test/x11_property_change_waiter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 19 chunks +37 lines, -39 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 24 chunks +46 lines, -44 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc View 9 chunks +10 lines, -9 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Tom Anderson
reviewers ptal sky: PRESUBMIT.py sadrul: everything else
3 years, 6 months ago (2017-06-08 21:31:59 UTC) #8
sky
presubmit LGTM
3 years, 6 months ago (2017-06-08 21:47:10 UTC) #9
sadrul
lgtm Thanks!
3 years, 6 months ago (2017-06-08 22:10:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924343002/40001
3 years, 6 months ago (2017-06-08 22:16:15 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 22:22:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/11aa41dc3c2e265a712b55d0a642...

Powered by Google App Engine
This is Rietveld 408576698