| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 184 True, | 184 True, |
| 185 ( | 185 ( |
| 186 r"^ui[\\\/]gl[\\\/].*\.cc$", | 186 r"^ui[\\\/]gl[\\\/].*\.cc$", |
| 187 r"^media[\\\/]gpu[\\\/].*\.cc$", | 187 r"^media[\\\/]gpu[\\\/].*\.cc$", |
| 188 r"^gpu[\\\/].*\.cc$", | 188 r"^gpu[\\\/].*\.cc$", |
| 189 ), | 189 ), |
| 190 ), | 190 ), |
| 191 ( | 191 ( |
| 192 r'XInternAtom|xcb_intern_atom', | 192 r'XInternAtom|xcb_intern_atom', |
| 193 ( | 193 ( |
| 194 'Use ui::GetAtom() or ui::X11AtomCache::GetAtom() instead of', | 194 'Use gfx::GetAtom() instead of interning atoms directly.', |
| 195 'interning atoms directly.', | |
| 196 ), | 195 ), |
| 197 True, | 196 True, |
| 198 ( | 197 ( |
| 198 r"^gpu[\\\/]ipc[\\\/]service[\\\/]gpu_watchdog_thread\.cc$", |
| 199 r"^remoting[\\\/]host[\\\/]linux[\\\/]x_server_clipboard\.cc$", |
| 199 r"^ui[\\\/]gfx[\\\/]x[\\\/]x11_atom_cache\.cc$", | 200 r"^ui[\\\/]gfx[\\\/]x[\\\/]x11_atom_cache\.cc$", |
| 200 ), | 201 ), |
| 201 ), | 202 ), |
| 202 ( | 203 ( |
| 203 'ScopedAllowIO', | 204 'ScopedAllowIO', |
| 204 ( | 205 ( |
| 205 'New production code should not use ScopedAllowIO (using it in', | 206 'New production code should not use ScopedAllowIO (using it in', |
| 206 'browser tests is fine). Post a task to the blocking pool or the', | 207 'browser tests is fine). Post a task to the blocking pool or the', |
| 207 'FILE thread instead.', | 208 'FILE thread instead.', |
| 208 ), | 209 ), |
| (...skipping 2308 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 2517 output_api, | 2518 output_api, |
| 2518 json_url='http://chromium-status.appspot.com/current?format=json')) | 2519 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 2519 | 2520 |
| 2520 results.extend( | 2521 results.extend( |
| 2521 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) | 2522 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) |
| 2522 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2523 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 2523 input_api, output_api)) | 2524 input_api, output_api)) |
| 2524 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2525 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 2525 input_api, output_api)) | 2526 input_api, output_api)) |
| 2526 return results | 2527 return results |
| OLD | NEW |