Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2924343002: Move ui::GetAtom to gfx::GetAtom (Closed)
Patch Set: fix CrOs build Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/host/ash_window_tree_host_x11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index c0324ab809eee63b845e7db0e0041b71edbe4ba3..46e16be0020af61368ec8834dec81a7fe1ede4ab 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -191,11 +191,12 @@ _BANNED_CPP_FUNCTIONS = (
(
r'XInternAtom|xcb_intern_atom',
(
- 'Use ui::GetAtom() or ui::X11AtomCache::GetAtom() instead of',
- 'interning atoms directly.',
+ 'Use gfx::GetAtom() instead of interning atoms directly.',
),
True,
(
+ r"^gpu[\\\/]ipc[\\\/]service[\\\/]gpu_watchdog_thread\.cc$",
+ r"^remoting[\\\/]host[\\\/]linux[\\\/]x_server_clipboard\.cc$",
r"^ui[\\\/]gfx[\\\/]x[\\\/]x11_atom_cache\.cc$",
),
),
« no previous file with comments | « no previous file | ash/host/ash_window_tree_host_x11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698