Copy improvement directions from telemetry to legacy_unit_info.

Copy improvement directions from telemetry to legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate it.
This CL adds improvement direction to legacy units so that legacy
benchmarks like blink_perf can display green/red delta scalars and significance
emoji.

https://benjhayden.users.x20web.corp.google.com/www/2924103002.html?r=blink_perf.css%0A2017-06-08%2016%3A50%3A53&s=%CE%94avg&g=name
Review-Url: https://codereview.chromium.org/2924103002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4a317a0c5d7db12211794ee926dc961e765b074e

[benjhayden, 2017-06-07 21:07:10]

Description was changed from

==========
Add improvement direction to some legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate improvement direction.
This CL adds improvement direction to some legacy units so that some legacy
metrics like blink_perf can display green/red delta scalars and significance
emoji.
==========

to

==========
Add improvement direction to some legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate improvement direction.
This CL adds improvement direction to some legacy units so that some legacy
metrics like blink_perf can display green/red delta scalars and significance
emoji.

http://www/~benjhayden/2924103002.html?r=blink_perf%0A2017-06-07%2020%3A36%3A...
==========

[benjhayden, 2017-06-07 21:07:55]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2017-06-07 21:07:56]

PTAL

[Bugs Nash, 2017-06-07 21:52:11]

bugsnash@chromium.org changed reviewers:
+ bugsnash@chromium.org

[Bugs Nash, 2017-06-07 21:52:11]

YASS

[benjhayden, 2017-06-08 16:49:10]

Description was changed from

==========
Add improvement direction to some legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate improvement direction.
This CL adds improvement direction to some legacy units so that some legacy
metrics like blink_perf can display green/red delta scalars and significance
emoji.

http://www/~benjhayden/2924103002.html?r=blink_perf%0A2017-06-07%2020%3A36%3A...
==========

to

==========
Copy improvement directions from telemetry to legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate it.
This CL adds improvement direction to legacy units so that legacy
benchmarks like blink_perf can display green/red delta scalars and significance
emoji.

http://www/~benjhayden/2924103002.html?r=blink_perf%0A2017-06-07%2020%3A36%3A...
==========

[benjhayden, 2017-06-08 17:11:54]

Description was changed from

==========
Copy improvement directions from telemetry to legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate it.
This CL adds improvement direction to legacy units so that legacy
benchmarks like blink_perf can display green/red delta scalars and significance
emoji.

http://www/~benjhayden/2924103002.html?r=blink_perf%0A2017-06-07%2020%3A36%3A...
==========

to

==========
Copy improvement directions from telemetry to legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate it.
This CL adds improvement direction to legacy units so that legacy
benchmarks like blink_perf can display green/red delta scalars and significance
emoji.

https://benjhayden.users.x20web.corp.google.com/www/2924103002.html?r=blink_p...
==========

[Bugs Nash, 2017-06-09 05:36:35]

lgtm

[eakuefner, 2017-06-09 17:31:27]

lgtm

[benjhayden, 2017-06-13 20:51:33]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2017-06-13 20:51:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 21:11:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 21:11:33]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[benjhayden, 2017-06-13 21:46:20]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-06-13 21:46:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2924103002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2017-06-13 21:46:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 22:13:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497390380548760,
"parent_rev": "36487978c43b55ab38f8d0ba4d698cae2aefed85", "commit_rev":
"4a317a0c5d7db12211794ee926dc961e765b074e"}

[commit-bot: I haz the power, 2017-06-13 22:13:24]

Description was changed from

==========
Copy improvement directions from telemetry to legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate it.
This CL adds improvement direction to legacy units so that legacy
benchmarks like blink_perf can display green/red delta scalars and significance
emoji.

https://benjhayden.users.x20web.corp.google.com/www/2924103002.html?r=blink_p...
==========

to

==========
Copy improvement directions from telemetry to legacy_unit_info.

Currently, all Histograms produced by converting chart-json lack improvement
direction, even legacy units whose names indicate it.
This CL adds improvement direction to legacy units so that legacy
benchmarks like blink_perf can display green/red delta scalars and significance
emoji.

https://benjhayden.users.x20web.corp.google.com/www/2924103002.html?r=blink_p...
Review-Url: https://codereview.chromium.org/2924103002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-06-13 22:13:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...