tracing/tracing/value/chart_json_converter_test.html - Issue 2924103002: Copy improvement directions from telemetry to legacy_unit_info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/value/chart_json_converter_test.html

Issue 2924103002: Copy improvement directions from telemetry to legacy_unit_info. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/value/chart_json_converter_test.html

diff --git a/tracing/tracing/value/chart_json_converter_test.html b/tracing/tracing/value/chart_json_converter_test.html

index b4aff0117f8872ccaadb8ed03483761dfa221088..ecb2f021d2ff2936f3293126fa14901f4aa20f3f 100644

--- a/tracing/tracing/value/chart_json_converter_test.html

+++ b/tracing/tracing/value/chart_json_converter_test.html

@@ -175,7 +175,8 @@ tr.b.unittest.testSuite(function() {

tr.v.HistogramSet.GROUPINGS.STORY_NAME.callback(hist));

assert.strictEqual(20, hist.average);

assert.strictEqual(4, hist.numValues);

- assert.strictEqual(tr.b.Unit.byName.timeDurationInMs, hist.unit);

+ assert.strictEqual(tr.b.Unit.byName.timeDurationInMs_smallerIsBetter,

+ hist.unit);

});

</script>