tracing/tracing/value/chart_json_converter_test.html - Issue 2924103002: Copy improvement directions from telemetry to legacy_unit_info.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tracing/tracing/value/chart_json_converter_test.html

Issue 2924103002: Copy improvement directions from telemetry to legacy_unit_info. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright 2016 The Chromium Authors. All rights reserved.	3 Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <link rel="import" href="/tracing/value/chart_json_converter.html">	8 <link rel="import" href="/tracing/value/chart_json_converter.html">

9 <link rel="import" href="/tracing/value/histogram_set.html">	9 <link rel="import" href="/tracing/value/histogram_set.html">

10	10

(...skipping 157 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
168 tr.v.ChartJsonConverter.convertChartJson(charts, histograms);	168 tr.v.ChartJsonConverter.convertChartJson(charts, histograms);

169 assert.lengthOf(histograms, 1);	169 assert.lengthOf(histograms, 1);

170 const hist = [...histograms][0];	170 const hist = [...histograms][0];

171 assert.strictEqual('MPArch_RWH_TabSwitchPaintDuration', hist.name);	171 assert.strictEqual('MPArch_RWH_TabSwitchPaintDuration', hist.name);

172 assert.strictEqual('',	172 assert.strictEqual('',

173 tr.v.HistogramSet.GROUPINGS.LEGACY_TIR_LABEL.callback(hist));	173 tr.v.HistogramSet.GROUPINGS.LEGACY_TIR_LABEL.callback(hist));

174 assert.strictEqual('',	174 assert.strictEqual('',

175 tr.v.HistogramSet.GROUPINGS.STORY_NAME.callback(hist));	175 tr.v.HistogramSet.GROUPINGS.STORY_NAME.callback(hist));

176 assert.strictEqual(20, hist.average);	176 assert.strictEqual(20, hist.average);

177 assert.strictEqual(4, hist.numValues);	177 assert.strictEqual(4, hist.numValues);

178 assert.strictEqual(tr.b.Unit.byName.timeDurationInMs, hist.unit);	178 assert.strictEqual(tr.b.Unit.byName.timeDurationInMs_smallerIsBetter,

	179 hist.unit);

179 });	180 });

180 });	181 });

181 </script>	182 </script>

OLD	NEW

« no previous file with comments | « tracing/tracing/value/chart_json_converter.html ('k') | tracing/tracing/value/legacy_unit_info.html » ('j') | no next file with comments »