predictors: Don't call IsUrlPrefetchable twice.

predictors: Don't call IsUrlPrefetchable twice.

Test cleanup as well.

BUG=715525
Review-Url: https://codereview.chromium.org/2923813002
Cr-Commit-Position: refs/heads/master@{#477616}
Committed: https://chromium.googlesource.com/chromium/src/+/05379193f1c2ee69e6b914bcf31625e434fb99ea

[Benoit L, 2017-06-06 16:28:47]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[Benoit L, 2017-06-06 16:28:54]

lizeb@chromium.org changed reviewers:
+ alexilin@chromium.org

[commit-bot: I haz the power, 2017-06-06 16:29:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexilin, 2017-06-06 16:43:33]

lgtm, I like this change! One more step towards moving triggering logic to
LoadingPredictor class.

https://codereview.chromium.org/2923813002/diff/40001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor.cc (left):

https://codereview.chromium.org/2923813002/diff/40001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor.cc:587:
DCHECK_CURRENTLY_ON(BrowserThread::UI);
nit:
Could you move a thread checking to GetPrefetchData() as well?

https://codereview.chromium.org/2923813002/diff/40001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor.cc (right):

https://codereview.chromium.org/2923813002/diff/40001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor.cc:742:
ResourcePrefetchPredictor::Prediction* prediction) const {
Thanks for fixing this! I forgot to add the check when I was moving this method
from private to public.

[commit-bot: I haz the power, 2017-06-06 17:18:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 17:18:38]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2017-06-07 08:50:27]

Thanks!

https://codereview.chromium.org/2923813002/diff/40001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor.cc (left):

https://codereview.chromium.org/2923813002/diff/40001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor.cc:587:
DCHECK_CURRENTLY_ON(BrowserThread::UI);
On 2017/06/06 16:43:32, alexilin wrote:
> nit:
> Could you move a thread checking to GetPrefetchData() as well?

Done.

[Benoit L, 2017-06-07 08:50:41]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2017-06-07 08:50:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexilin@chromium.org
Link to the patchset: https://codereview.chromium.org/2923813002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-06-07 08:50:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 08:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 08:54:36]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Benoit L, 2017-06-07 09:28:58]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 09:29:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 09:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 09:50:46]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2017-06-07 12:02:25]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2017-06-07 12:02:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 12:07:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496836945761900,
"parent_rev": "669a9a330cdd60157347afe4e34f688b123353b1", "commit_rev":
"05379193f1c2ee69e6b914bcf31625e434fb99ea"}

[commit-bot: I haz the power, 2017-06-07 12:07:25]

Description was changed from

==========
predictors: Don't call IsUrlPrefetchable twice.

Test cleanup as well.

BUG=715525
==========

to

==========
predictors: Don't call IsUrlPrefetchable twice.

Test cleanup as well.

BUG=715525

Review-Url: https://codereview.chromium.org/2923813002
Cr-Commit-Position: refs/heads/master@{#477616}
Committed:
https://chromium.googlesource.com/chromium/src/+/05379193f1c2ee69e6b914bcf316...
==========

[commit-bot: I haz the power, 2017-06-07 12:07:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/05379193f1c2ee69e6b914bcf316...