Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: chrome/browser/predictors/loading_predictor_unittest.cc

Issue 2923813002: predictors: Don't call IsUrlPrefetchable twice. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/loading_predictor_unittest.cc
diff --git a/chrome/browser/predictors/loading_predictor_unittest.cc b/chrome/browser/predictors/loading_predictor_unittest.cc
index 9ba0d82a4abf2c653bfd273fafd04dc131e6eccd..ee090403f597b1508a849a0ee4d4d89ca672e4f5 100644
--- a/chrome/browser/predictors/loading_predictor_unittest.cc
+++ b/chrome/browser/predictors/loading_predictor_unittest.cc
@@ -18,6 +18,10 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+using testing::_;
+using testing::Return;
+using testing::StrictMock;
+
namespace predictors {
namespace {
@@ -52,10 +56,17 @@ void LoadingPredictorTest::SetUp() {
LoadingPredictorConfig config;
PopulateTestConfig(&config);
predictor_ = base::MakeUnique<LoadingPredictor>(config, profile_.get());
- auto mock =
- base::MakeUnique<MockResourcePrefetchPredictor>(config, profile_.get());
- mock->AddPrefetchableUrl(GURL(kUrl));
- mock->AddPrefetchableUrl(GURL(kUrl2));
+
+ auto mock = base::MakeUnique<StrictMock<MockResourcePrefetchPredictor>>(
+ config, profile_.get());
+ EXPECT_CALL(*mock, StartInitialization());
+ EXPECT_CALL(*mock, GetPrefetchData(GURL(kUrl), _))
+ .WillRepeatedly(Return(true));
+ EXPECT_CALL(*mock, GetPrefetchData(GURL(kUrl2), _))
+ .WillRepeatedly(Return(true));
+ EXPECT_CALL(*mock, GetPrefetchData(GURL(kUrl3), _))
+ .WillRepeatedly(Return(false));
+
predictor_->set_mock_resource_prefetch_predictor(std::move(mock));
predictor_->StartInitialization();
base::RunLoop().RunUntilIdle();
@@ -68,10 +79,10 @@ void LoadingPredictorTest::TearDown() {
TEST_F(LoadingPredictorTest, TestPrefetchingDurationHistogram) {
base::HistogramTester histogram_tester;
-
const GURL url = GURL(kUrl);
const GURL url2 = GURL(kUrl2);
const GURL url3 = GURL(kUrl3);
+
predictor_->PrepareForPageLoad(url, HintOrigin::EXTERNAL);
predictor_->CancelPageLoadHint(url);
histogram_tester.ExpectTotalCount(
« no previous file with comments | « chrome/browser/predictors/loading_predictor.cc ('k') | chrome/browser/predictors/resource_prefetch_predictor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698