predictors: Don't call IsUrlPrefetchable twice.

chrome/browser/predictors/loading_predictor_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/predictors/loading_predictor.h"
 
 #include <memory>
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/run_loop.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/browser/predictors/resource_prefetch_predictor_test_util.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+using testing::_;
+using testing::Return;
+using testing::StrictMock;
+
 namespace predictors {
 
 namespace {
 // First two are prefetchable, last one is not (see SetUp()).
 const char kUrl[] = "http://www.google.com/cats";
 const char kUrl2[] = "http://www.google.com/dogs";
 const char kUrl3[] = "https://unknown.website/catsanddogs";
 }
 
 class LoadingPredictorTest : public testing::Test {
@@ skipping 14 matching lines @@
 
 LoadingPredictorTest::~LoadingPredictorTest() {
   profile_ = nullptr;
   base::RunLoop().RunUntilIdle();
 }
 
 void LoadingPredictorTest::SetUp() {
   LoadingPredictorConfig config;
   PopulateTestConfig(&config);
   predictor_ = base::MakeUnique<LoadingPredictor>(config, profile_.get());
-  auto mock =
-      base::MakeUnique<MockResourcePrefetchPredictor>(config, profile_.get());
-  mock->AddPrefetchableUrl(GURL(kUrl));
-  mock->AddPrefetchableUrl(GURL(kUrl2));
+
+  auto mock = base::MakeUnique<StrictMock<MockResourcePrefetchPredictor>>(
+      config, profile_.get());
+  EXPECT_CALL(*mock, StartInitialization());
+  EXPECT_CALL(*mock, GetPrefetchData(GURL(kUrl), _))
+      .WillRepeatedly(Return(true));
+  EXPECT_CALL(*mock, GetPrefetchData(GURL(kUrl2), _))
+      .WillRepeatedly(Return(true));
+  EXPECT_CALL(*mock, GetPrefetchData(GURL(kUrl3), _))
+      .WillRepeatedly(Return(false));
+
   predictor_->set_mock_resource_prefetch_predictor(std::move(mock));
   predictor_->StartInitialization();
   base::RunLoop().RunUntilIdle();
 }
 
 void LoadingPredictorTest::TearDown() {
   predictor_ = nullptr;
   profile_->DestroyHistoryService();
 }
 
 TEST_F(LoadingPredictorTest, TestPrefetchingDurationHistogram) {
   base::HistogramTester histogram_tester;
-
   const GURL url = GURL(kUrl);
   const GURL url2 = GURL(kUrl2);
   const GURL url3 = GURL(kUrl3);
+
   predictor_->PrepareForPageLoad(url, HintOrigin::EXTERNAL);
   predictor_->CancelPageLoadHint(url);
   histogram_tester.ExpectTotalCount(
       internal::kResourcePrefetchPredictorPrefetchingDurationHistogram, 1);
 
   // Mismatched start / end.
   predictor_->PrepareForPageLoad(url, HintOrigin::EXTERNAL);
   predictor_->CancelPageLoadHint(url2);
   // No increment.
   histogram_tester.ExpectTotalCount(
@@ skipping 105 matching lines @@
   EXPECT_EQ(start_time, it->second);
 }
 
 TEST_F(LoadingPredictorTest, TestDontTrackNonPrefetchableUrls) {
   const GURL url3 = GURL(kUrl3);
   predictor_->PrepareForPageLoad(url3, HintOrigin::EXTERNAL);
   EXPECT_TRUE(predictor_->active_hints_.empty());
 }
 
 }  // namespace predictors