Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2923643002: Revert "bluetooth: bluez: Fixed issue with missing notifications after reconnect." (Closed)

Created:
3 years, 6 months ago by gkihumba
Modified:
3 years, 6 months ago
Reviewers:
scheib, ortuno, perja, rkc1
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert "bluetooth: bluez: Fixed issue with missing notifications after reconnect." Doesn't fix the original issue of notifications failing after reconnect https://crbug.com/680099 correctly. Introduces new issue: startCharacteristicNotifications returns 'Operation failed' after disconnect https://crbug.com/719581 This reverts commit db61493317991225f05f657bc5c78db7f96d55a7. originally from https://codereview.chromium.org/2625013003/ TBR=ortuno@chromium.org,rkc@google.com,scheib@chromium.org,perja@opera.com BUG=680099, 719581 Review-Url: https://codereview.chromium.org/2888663002 Cr-Original-Commit-Position: refs/heads/master@{#472290} Review-Url: https://codereview.chromium.org/2923643002 . Cr-Commit-Position: refs/branch-heads/3071@{#747} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/cb16911775ae92e1464b37dc3ca1ce98e832bca1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M device/bluetooth/bluetooth_device.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_device.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 1 chunk +4 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_device_bluez.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gkihumba
3 years, 6 months ago (2017-06-05 18:33:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb16911775ae92e1464b37dc3ca1ce98e832bca1.

Powered by Google App Engine
This is Rietveld 408576698