device/bluetooth/bluetooth_low_energy_device_mac.mm - Issue 2923643002: Revert "bluetooth: bluez: Fixed issue with missing notifications after reconnect."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_low_energy_device_mac.mm

Issue 2923643002: Revert "bluetooth: bluez: Fixed issue with missing notifications after reconnect." (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/bluetooth_low_energy_device_mac.mm

diff --git a/device/bluetooth/bluetooth_low_energy_device_mac.mm b/device/bluetooth/bluetooth_low_energy_device_mac.mm

index 20694e4953b97d7ca5d4edc882a0a4b0aab06864..6d41c6e10f61259d02cf2adc198462607b11bf23 100644

--- a/device/bluetooth/bluetooth_low_energy_device_mac.mm

+++ b/device/bluetooth/bluetooth_low_energy_device_mac.mm

@@ -453,7 +453,7 @@ void BluetoothLowEnergyDeviceMac::DidDisconnectPeripheral(NSError* error) {

// 2. When we cancel a pending connection request.

if (create_gatt_connection_error_callbacks_.empty()) {

// If there are no pending callbacks then the connection broke (#1).

- DidDisconnectGatt(true /* notifyDeviceChanged */);

+ DidDisconnectGatt();

return;

}

// Else we canceled the connection request (#2).