Chromium Code Reviews

Issue 2888663002: Revert "bluetooth: bluez: Fixed issue with missing notifications after reconnect." (Closed)

Created:
3 years, 7 months ago by Sonny Sasaka
Modified:
3 years, 7 months ago
Reviewers:
rkc, scheib, ortuno, perja, rkc1
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "bluetooth: bluez: Fixed issue with missing notifications after reconnect." Doesn't fix the original issue of notifications failing after reconnect https://crbug.com/680099 correctly. Introduces new issue: startCharacteristicNotifications returns 'Operation failed' after disconnect https://crbug.com/719581 This reverts commit db61493317991225f05f657bc5c78db7f96d55a7. originally from https://codereview.chromium.org/2625013003/ TBR=ortuno@chromium.org,rkc@google.com,scheib@chromium.org,perja@opera.com BUG=680099, 719581 Review-Url: https://codereview.chromium.org/2888663002 Cr-Commit-Position: refs/heads/master@{#472290} Committed: https://chromium.googlesource.com/chromium/src/+/acfce3dfacf54420df8a3118e9433dbb36d70177

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+8 lines, -13 lines)
M device/bluetooth/bluetooth_device.h View 1 chunk +1 line, -1 line 0 comments
M device/bluetooth/bluetooth_device.cc View 2 chunks +2 lines, -7 lines 0 comments
M device/bluetooth/bluetooth_device_android.cc View 1 chunk +4 lines, -1 line 0 comments
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 chunk +1 line, -1 line 0 comments
M device/bluetooth/bluez/bluetooth_device_bluez.cc View 1 chunk +0 lines, -3 lines 0 comments

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888663002/1
3 years, 7 months ago (2017-05-16 19:21:55 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-16 19:21:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888663002/1
3 years, 7 months ago (2017-05-16 19:26:07 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-16 19:26:08 UTC) #8
rkc
lgtm
3 years, 7 months ago (2017-05-16 19:34:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888663002/1
3 years, 7 months ago (2017-05-16 19:35:09 UTC) #11
scheib
On 2017/05/16 19:35:09, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 7 months ago (2017-05-16 20:17:43 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 02:30:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/acfce3dfacf54420df8a3118e943...

Powered by Google App Engine