Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2923403002: Drop SSLv3 cache entries (Closed)

Created:
3 years, 6 months ago by estark
Modified:
3 years, 6 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, lgarron+watch_chromium.org, raymes+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop SSLv3 cache entries SSLv3 is gone so we no longer need to load cache entries. Doing so allows us to remove SSLv3 logic from UI surfaces, as I've done for Page Info in this CL. BUG=652505 Review-Url: https://codereview.chromium.org/2923403002 Cr-Commit-Position: refs/heads/master@{#477730} Committed: https://chromium.googlesource.com/chromium/src/+/3bd7dd5df8fae5704a56611364b34a1c0a17dabd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M chrome/browser/ui/page_info/page_info.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/http/http_response_info.cc View 1 chunk +6 lines, -0 lines 1 comment Download
M net/http/http_response_info_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
estark
davidben, PTAL?
3 years, 6 months ago (2017-06-07 06:05:02 UTC) #4
davidben
lgtm https://codereview.chromium.org/2923403002/diff/1/net/http/http_response_info.cc File net/http/http_response_info.cc (right): https://codereview.chromium.org/2923403002/diff/1/net/http/http_response_info.cc#newcode245 net/http/http_response_info.cc:245: SSL_CONNECTION_VERSION_SSL3) { TBH, I'd be surprised if these ...
3 years, 6 months ago (2017-06-07 19:28:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923403002/1
3 years, 6 months ago (2017-06-07 19:36:10 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 19:42:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bd7dd5df8fae5704a56611364b3...

Powered by Google App Engine
This is Rietveld 408576698