Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: net/http/http_response_info.cc

Issue 2923403002: Drop SSLv3 cache entries (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/page_info/page_info.cc ('k') | net/http/http_response_info_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_response_info.h" 5 #include "net/http/http_response_info.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/pickle.h" 8 #include "base/pickle.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "net/base/auth.h" 10 #include "net/base/auth.h"
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 int security_bits; 232 int security_bits;
233 if (!iter.ReadInt(&security_bits)) 233 if (!iter.ReadInt(&security_bits))
234 return false; 234 return false;
235 ssl_info.security_bits = security_bits; 235 ssl_info.security_bits = security_bits;
236 } 236 }
237 237
238 if (flags & RESPONSE_INFO_HAS_SSL_CONNECTION_STATUS) { 238 if (flags & RESPONSE_INFO_HAS_SSL_CONNECTION_STATUS) {
239 int connection_status; 239 int connection_status;
240 if (!iter.ReadInt(&connection_status)) 240 if (!iter.ReadInt(&connection_status))
241 return false; 241 return false;
242
243 // SSLv3 is gone, so drop cached entries that were loaded over SSLv3.
244 if (SSLConnectionStatusToVersion(connection_status) ==
245 SSL_CONNECTION_VERSION_SSL3) {
davidben 2017/06/07 19:28:13 TBH, I'd be surprised if these cache entries still
246 return false;
247 }
242 ssl_info.connection_status = connection_status; 248 ssl_info.connection_status = connection_status;
243 } 249 }
244 250
245 if (flags & RESPONSE_INFO_HAS_SIGNED_CERTIFICATE_TIMESTAMPS) { 251 if (flags & RESPONSE_INFO_HAS_SIGNED_CERTIFICATE_TIMESTAMPS) {
246 int num_scts; 252 int num_scts;
247 if (!iter.ReadInt(&num_scts)) 253 if (!iter.ReadInt(&num_scts))
248 return false; 254 return false;
249 for (int i = 0; i < num_scts; ++i) { 255 for (int i = 0; i < num_scts; ++i) {
250 scoped_refptr<ct::SignedCertificateTimestamp> sct( 256 scoped_refptr<ct::SignedCertificateTimestamp> sct(
251 ct::SignedCertificateTimestamp::CreateFromPickle(&iter)); 257 ct::SignedCertificateTimestamp::CreateFromPickle(&iter));
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 case CONNECTION_INFO_HTTP1_0: 500 case CONNECTION_INFO_HTTP1_0:
495 return "http/1.0"; 501 return "http/1.0";
496 case NUM_OF_CONNECTION_INFOS: 502 case NUM_OF_CONNECTION_INFOS:
497 break; 503 break;
498 } 504 }
499 NOTREACHED(); 505 NOTREACHED();
500 return ""; 506 return "";
501 } 507 }
502 508
503 } // namespace net 509 } // namespace net
OLDNEW
« no previous file with comments | « chrome/browser/ui/page_info/page_info.cc ('k') | net/http/http_response_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698