Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: net/http/http_response_info.cc

Issue 2923403002: Drop SSLv3 cache entries (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/page_info/page_info.cc ('k') | net/http/http_response_info_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_info.cc
diff --git a/net/http/http_response_info.cc b/net/http/http_response_info.cc
index f0ee33e0eeb693c81cbb395614b83f5c54f473b3..0104dbf7fa31bac758ff35d506728104d85b34a4 100644
--- a/net/http/http_response_info.cc
+++ b/net/http/http_response_info.cc
@@ -239,6 +239,12 @@ bool HttpResponseInfo::InitFromPickle(const base::Pickle& pickle,
int connection_status;
if (!iter.ReadInt(&connection_status))
return false;
+
+ // SSLv3 is gone, so drop cached entries that were loaded over SSLv3.
+ if (SSLConnectionStatusToVersion(connection_status) ==
+ SSL_CONNECTION_VERSION_SSL3) {
davidben 2017/06/07 19:28:13 TBH, I'd be surprised if these cache entries still
+ return false;
+ }
ssl_info.connection_status = connection_status;
}
« no previous file with comments | « chrome/browser/ui/page_info/page_info.cc ('k') | net/http/http_response_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698