Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2923043003: VR: Split off UI code into a library to ease future unit testing. (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Split off UI code into a library to ease future unit testing. This new library contains most "utility" and UI code, which is platform independent and easily testable. The original library contains core, Android, threading, etc. This is a step towards being able to build a small unit test binary, and run it on Linux. To allow the split, add a GL renderer interface to hide the GL thread from UI elements. BUG=727396 Review-Url: https://codereview.chromium.org/2903363002 Cr-Original-Commit-Position: refs/heads/master@{#475516} Review-Url: https://codereview.chromium.org/2923043003 . Cr-Commit-Position: refs/branch-heads/3112@{#191} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/193ebc46e5070c5bc855234f8a02d90c8903b69b

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
cjgrant
3 years, 6 months ago (2017-06-06 18:10:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
193ebc46e5070c5bc855234f8a02d90c8903b69b.

Powered by Google App Engine
This is Rietveld 408576698