VR: Split off UI code into a library to ease future unit testing.

VR: Split off UI code into a library to ease future unit testing.

This new library contains most "utility" and UI code, which is platform
independent and easily testable.  The original library contains core,
Android, threading, etc.  This is a step towards being able to build a
small unit test binary, and run it on Linux.

To allow the split, add a GL renderer interface to hide the GL thread
from UI elements.

BUG=727396
Review-Url: https://codereview.chromium.org/2903363002
Cr-Commit-Position: refs/heads/master@{#475516}
Committed: https://chromium.googlesource.com/chromium/src/+/18addc1ee2e63344ce882005e48c2e509a7402b5

[cjgrant, 2017-05-25 22:47:47]

cjgrant@chromium.org changed reviewers:
+ amp@chromium.org, mthiesse@chromium.org, tiborg@chromium.org,
vollick@chromium.org

[cjgrant, 2017-05-25 22:47:48]

Folks, a bit of a side work here en route to less painful unit test execution.

Next step is to lop off the "ui" library, call it something better, and
hopefully move it to components.

[cjgrant, 2017-05-25 22:49:10]

On 2017/05/25 22:47:48, cjgrant wrote:
> Folks, a bit of a side work here en route to less painful unit test execution.
> 
> Next step is to lop off the "ui" library, call it something better, and
> hopefully move it to components.

And this needs cleanup; I'm just looking for a sanity check at this point.

[amp, 2017-05-25 23:21:47]

Looks like a good improvement and separation.  Glad to see something that can
start to look like the Vnext architecture.

[mthiesse, 2017-05-29 17:00:59]

lgtm

In a follow-up we should probably make our build target names more sensible.
vr_common probably shouldn't be vr_common.

[mthiesse, 2017-05-29 17:01:31]

Might want to hold off on landing this one though until we've finished the stuff
we need to merge back?

[cjgrant, 2017-05-29 17:13:11]

On 2017/05/29 17:01:31, mthiesse wrote:
> Might want to hold off on landing this one though until we've finished the
stuff
> we need to merge back?

Agree that the current vr-common isn't vr-common.

Given that the change isn't actually changing much code, it might be good just
to merge it back as well, IMO, unless merging is painful.  Will be coming back
to this after we get our initial CLs all merged.

[cjgrant, 2017-05-29 20:55:04]

Description was changed from

==========
[Work in progress] VR: Split build file into two libraries to improve unit
testing.

One library contains most "utility" and UI code, which is platform
independent and easily testable.  The other contains core, Android,
threading, etc.  This is a step towards being able to build a small unit
test binary, and run it on Linux.

To allow the split, add a GL renderer interface to hide the GL thread
from UI elements.

BUG=
==========

to

==========
VR: Split off UI code into a library to ease future unit testing.

This new library contains most "utility" and UI code, which is platform
independent and easily testable.  The original library contains core,
Android, threading, etc.  This is a step towards being able to build a
small unit test binary, and run it on Linux.

To allow the split, add a GL renderer interface to hide the GL thread
from UI elements.

BUG=727396
==========

[cjgrant, 2017-05-29 21:07:13]

The CQ bit was checked by cjgrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 21:07:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 22:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 22:21:52]

Dry run: This issue passed the CQ dry run.

[Ian Vollick, 2017-05-30 13:08:58]

On 2017/05/29 17:13:11, cjgrant wrote:
> On 2017/05/29 17:01:31, mthiesse wrote:
> > Might want to hold off on landing this one though until we've finished the
> stuff
> > we need to merge back?
> 
> Agree that the current vr-common isn't vr-common.
> 
> Given that the change isn't actually changing much code, it might be good just
> to merge it back as well, IMO, unless merging is painful.  Will be coming back
> to this after we get our initial CLs all merged.

lgtm.

[cjgrant, 2017-05-30 13:41:23]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-05-30 13:41:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2903363002/#ps40001
(title: "More tweaks.")

[commit-bot: I haz the power, 2017-05-30 13:41:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 13:44:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496151683436810,
"parent_rev": "60f73b2110522209cd44f7c7328dd234def75ba6", "commit_rev":
"18addc1ee2e63344ce882005e48c2e509a7402b5"}

[commit-bot: I haz the power, 2017-05-30 13:44:38]

Description was changed from

==========
VR: Split off UI code into a library to ease future unit testing.

This new library contains most "utility" and UI code, which is platform
independent and easily testable.  The original library contains core,
Android, threading, etc.  This is a step towards being able to build a
small unit test binary, and run it on Linux.

To allow the split, add a GL renderer interface to hide the GL thread
from UI elements.

BUG=727396
==========

to

==========
VR: Split off UI code into a library to ease future unit testing.

This new library contains most "utility" and UI code, which is platform
independent and easily testable.  The original library contains core,
Android, threading, etc.  This is a step towards being able to build a
small unit test binary, and run it on Linux.

To allow the split, add a GL renderer interface to hide the GL thread
from UI elements.

BUG=727396

Review-Url: https://codereview.chromium.org/2903363002
Cr-Commit-Position: refs/heads/master@{#475516}
Committed:
https://chromium.googlesource.com/chromium/src/+/18addc1ee2e63344ce882005e48c...
==========

[commit-bot: I haz the power, 2017-05-30 13:44:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/18addc1ee2e63344ce882005e48c...