[arm64] Fix assertion in IsImmLLiteral and enable literal pool tests.

[arm64] Fix assertion in IsImmLLiteral and enable literal pool tests.

BUG=

Review-Url: https://codereview.chromium.org/2922983002
Cr-Commit-Position: refs/heads/master@{#45948}
Committed: https://chromium.googlesource.com/v8/v8/+/51a6789bed45e6607ed4000f2076f1fdaef8fdba

[georgia.kouveli, 2017-06-05 13:21:21]

georgia.kouveli@arm.com changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org, tebbi@chromium.org

[georgia.kouveli, 2017-06-13 14:03:38]

Ping! Any comments on this change?

[Jarin, 2017-06-13 14:21:55]

lgtm

https://codereview.chromium.org/2922983002/diff/1/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):

https://codereview.chromium.org/2922983002/diff/1/src/arm64/assembler-arm64.h...
src/arm64/assembler-arm64.h:3499: int GetConstantPoolEntriesSize() const {
Normally testing functions have ForTesting suffix. Could you add that?

(I believe some part of presubmit checks then makes sure that *ForTesting
function are only used from tests.)

https://codereview.chromium.org/2922983002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-arm64.cc (right):

https://codereview.chromium.org/2922983002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-arm64.cc:246: printf("constant pool size is: %d\n",
__ GetConstantPoolEntriesSize()); \
Remove the printf?

[georgia.kouveli, 2017-06-14 09:46:10]

https://codereview.chromium.org/2922983002/diff/1/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):

https://codereview.chromium.org/2922983002/diff/1/src/arm64/assembler-arm64.h...
src/arm64/assembler-arm64.h:3499: int GetConstantPoolEntriesSize() const {
On 2017/06/13 14:21:55, Jarin wrote:
> Normally testing functions have ForTesting suffix. Could you add that?
> 
> (I believe some part of presubmit checks then makes sure that *ForTesting
> function are only used from tests.)

Done.

https://codereview.chromium.org/2922983002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-arm64.cc (right):

https://codereview.chromium.org/2922983002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-arm64.cc:246: printf("constant pool size is: %d\n",
__ GetConstantPoolEntriesSize()); \
On 2017/06/13 14:21:55, Jarin wrote:
> Remove the printf?

Done.

[georgia.kouveli, 2017-06-14 13:16:05]

The CQ bit was checked by georgia.kouveli@arm.com

[georgia.kouveli, 2017-06-14 13:16:05]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2922983002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-06-14 13:16:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 13:52:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497446165286750,
"parent_rev": "b1ee17e588987f31d36658e733f67a9f7b971dae", "commit_rev":
"51a6789bed45e6607ed4000f2076f1fdaef8fdba"}

[commit-bot: I haz the power, 2017-06-14 13:52:07]

Description was changed from

==========
[arm64] Fix assertion in IsImmLLiteral and enable literal pool tests.

BUG=
==========

to

==========
[arm64] Fix assertion in IsImmLLiteral and enable literal pool tests.

BUG=

Review-Url: https://codereview.chromium.org/2922983002
Cr-Commit-Position: refs/heads/master@{#45948}
Committed:
https://chromium.googlesource.com/v8/v8/+/51a6789bed45e6607ed4000f2076f1fdaef...
==========

[commit-bot: I haz the power, 2017-06-14 13:52:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/51a6789bed45e6607ed4000f2076f1fdaef...