Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: test/cctest/test-disasm-arm64.cc

Issue 2922983002: [arm64] Fix assertion in IsImmLLiteral and enable literal pool tests. (Closed)
Patch Set: Address comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-assembler-arm64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-disasm-arm64.cc
diff --git a/test/cctest/test-disasm-arm64.cc b/test/cctest/test-disasm-arm64.cc
index d78ac5d3bf1b8aa6d7ff325872b60ad83092e85b..6705204b4c4095bcddf66b69595d95b44a3c3634 100644
--- a/test/cctest/test-disasm-arm64.cc
+++ b/test/cctest/test-disasm-arm64.cc
@@ -1483,18 +1483,20 @@ TEST_(load_store_acquire_release) {
CLEANUP();
}
-#if 0 // TODO(all): enable.
TEST_(load_literal) {
SET_UP_ASM();
- COMPARE_PREFIX(ldr(x10, 0x1234567890abcdefUL), "ldr x10, pc+8");
- COMPARE_PREFIX(ldr(w20, 0xfedcba09), "ldr w20, pc+8");
- COMPARE_PREFIX(ldr(d11, 1.234), "ldr d11, pc+8");
- COMPARE_PREFIX(ldr(s22, 2.5f), "ldr s22, pc+8");
+ COMPARE_PREFIX(ldr_pcrel(x10, 0), "ldr x10, pc+0");
+ COMPARE_PREFIX(ldr_pcrel(x10, 1), "ldr x10, pc+4");
+ COMPARE_PREFIX(ldr_pcrel(d11, 0), "ldr d11, pc+0");
+ COMPARE_PREFIX(ldr_pcrel(d11, 1), "ldr d11, pc+4");
+
+ int max_offset = (kMaxLoadLiteralRange >> kLoadLiteralScaleLog2) - 1;
+ COMPARE_PREFIX(ldr_pcrel(x0, max_offset), "ldr x0, pc+1048572");
+ COMPARE_PREFIX(ldr_pcrel(d0, max_offset), "ldr d0, pc+1048572");
CLEANUP();
}
-#endif
TEST_(cond_select) {
SET_UP_ASM();
« no previous file with comments | « test/cctest/test-assembler-arm64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698