Chromium Code Reviews
DescriptionRevert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of https://codereview.chromium.org/2763223003/ )
(Original revert Modified to fix a merge conflict on M59)
Reason for revert:
crbug.com/724812
Original issue's description:
> cc: Don't use StreamVideoDrawQuad on any platform but Android.
>
> VideoLayerImpl is appending StreamVideoDrawQuads on CrOS.
>
> StreamVideoDrawQuads should be used on Android since almost all its
> features are supported by TextureDrawQuad.
> The only difference is that StreamVideoDrawQuad calls
> glUniformMatrix4fvStreamTextureMatrixCHROMIUM before drawing, that
> just sets a uniform matrix on CrOS.
>
> This CL makes sure VideoLayerImpl produces StreamVideoDrawQuads only
> on Android.
>
> BUG=702750
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2763223003
> Cr-Commit-Position: refs/heads/master@{#460547}
> Committed: https://chromium.googlesource.com/chromium/src/+/517d0115d3c435383f79a0b730b6514a6cc97f44
TBR=danakj@chromium.org,reveman@chromium.org,avi@chromium.org,dcastagna@chromium.org
BUG=702750
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2920893003
Cr-Original-Commit-Position: refs/heads/master@{#476523}
Review-Url: https://codereview.chromium.org/2922113002 .
Cr-Commit-Position: refs/branch-heads/3071@{#745}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/4377e1fc59dab874287825f97544876857dd49a2
Patch Set 1 #Patch Set 2 : Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of h… #
Messages
Total messages: 12 (7 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||