Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 2922113002: Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of h… (Closed)

Created:
3 years, 6 months ago by Pawel Osciak
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of https://codereview.chromium.org/2763223003/ ) (Original revert Modified to fix a merge conflict on M59) Reason for revert: crbug.com/724812 Original issue's description: > cc: Don't use StreamVideoDrawQuad on any platform but Android. > > VideoLayerImpl is appending StreamVideoDrawQuads on CrOS. > > StreamVideoDrawQuads should be used on Android since almost all its > features are supported by TextureDrawQuad. > The only difference is that StreamVideoDrawQuad calls > glUniformMatrix4fvStreamTextureMatrixCHROMIUM before drawing, that > just sets a uniform matrix on CrOS. > > This CL makes sure VideoLayerImpl produces StreamVideoDrawQuads only > on Android. > > BUG=702750 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2763223003 > Cr-Commit-Position: refs/heads/master@{#460547} > Committed: https://chromium.googlesource.com/chromium/src/+/517d0115d3c435383f79a0b730b6514a6cc97f44 TBR=danakj@chromium.org,reveman@chromium.org,avi@chromium.org,dcastagna@chromium.org BUG=702750 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2920893003 Cr-Original-Commit-Position: refs/heads/master@{#476523} Review-Url: https://codereview.chromium.org/2922113002 . Cr-Commit-Position: refs/branch-heads/3071@{#745} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4377e1fc59dab874287825f97544876857dd49a2

Patch Set 1 #

Patch Set 2 : Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of h… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -90 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M cc/resources/video_resource_updater.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 14 chunks +13 lines, -58 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922113002/1
3 years, 6 months ago (2017-06-05 01:56:42 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-06-05 01:56:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922113002/1
3 years, 6 months ago (2017-06-05 01:59:48 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-06-05 01:59:50 UTC) #10
Pawel Osciak
3 years, 6 months ago (2017-06-05 03:35:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4377e1fc59dab874287825f97544876857dd49a2.

Powered by Google App Engine
This is Rietveld 408576698