Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2920893003: Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (Closed)

Created:
3 years, 6 months ago by Pawel Osciak
Modified:
3 years, 6 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, inactive_dshwang_plz_cc_intel, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of https://codereview.chromium.org/2763223003/ ) Reason for revert: crbug.com/724812 Original issue's description: > cc: Don't use StreamVideoDrawQuad on any platform but Android. > > VideoLayerImpl is appending StreamVideoDrawQuads on CrOS. > > StreamVideoDrawQuads should be used on Android since almost all its > features are supported by TextureDrawQuad. > The only difference is that StreamVideoDrawQuad calls > glUniformMatrix4fvStreamTextureMatrixCHROMIUM before drawing, that > just sets a uniform matrix on CrOS. > > This CL makes sure VideoLayerImpl produces StreamVideoDrawQuads only > on Android. > > BUG=702750 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2763223003 > Cr-Commit-Position: refs/heads/master@{#460547} > Committed: https://chromium.googlesource.com/chromium/src/+/517d0115d3c435383f79a0b730b6514a6cc97f44 TBR=danakj@chromium.org,reveman@chromium.org,avi@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702750 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2920893003 Cr-Commit-Position: refs/heads/master@{#476523} Committed: https://chromium.googlesource.com/chromium/src/+/30d6d64a9b914d1e4b1584cf62b9e64adc20de9d

Patch Set 1 #

Patch Set 2 : Fix merge conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -89 lines) Patch
M cc/layers/video_layer_impl.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 2 chunks +7 lines, -10 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 4 chunks +7 lines, -12 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 1 14 chunks +13 lines, -58 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Pawel Osciak
Created Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android.
3 years, 6 months ago (2017-06-02 00:05:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920893003/1
3 years, 6 months ago (2017-06-02 00:06:00 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/223989) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-02 00:09:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920893003/140001
3 years, 6 months ago (2017-06-02 00:25:19 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 02:15:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/30d6d64a9b914d1e4b1584cf62b9...

Powered by Google App Engine
This is Rietveld 408576698