Ensure promo dialogs are dismissed when activities are destroyed.

Ensure promo dialogs are dismissed when activities are destroyed.

BUG=727959
Review-Url: https://codereview.chromium.org/2921453003
Cr-Commit-Position: refs/heads/master@{#476452}
Committed: https://chromium.googlesource.com/chromium/src/+/4ca61512813b424e238dd5dc546d3f4b92991023

[Ted C, 2017-05-31 19:24:44]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ted C, 2017-05-31 19:24:45]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ted C, 2017-05-31 19:24:45]

PTAL

[Ted C, 2017-05-31 19:24:45]

PTAL

[gone, 2017-06-01 20:50:50]

https://codereview.chromium.org/2921453003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
(right):

https://codereview.chromium.org/2921453003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java:130:
// to respond to the dialog next time.
This could happen if the Activity dies now, I guess.

https://codereview.chromium.org/2921453003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java
(right):

https://codereview.chromium.org/2921453003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java:45:
//                crbug.com/728297
Does it make more sense to start up another suite for this because it's starting
an Activity?  This one just does measurements and things.

[Ted C, 2017-06-01 20:56:31]

https://codereview.chromium.org/2921453003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
(right):

https://codereview.chromium.org/2921453003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java:130:
// to respond to the dialog next time.
On 2017/06/01 20:50:50, dfalcantara wrote:
> This could happen if the Activity dies now, I guess.

Done.

https://codereview.chromium.org/2921453003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java
(right):

https://codereview.chromium.org/2921453003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java:45:
//                crbug.com/728297
On 2017/06/01 20:50:50, dfalcantara wrote:
> Does it make more sense to start up another suite for this because it's
starting
> an Activity?  This one just does measurements and things.

But creating the dialog requires an activity, you can't use it without one.  I
don't know what that would accomplish.

The activity needs a context bound to it to inflate anything, so none of the
setup would work in the dialog creation without it.

[gone, 2017-06-01 20:57:28]

On 2017/06/01 20:56:31, Ted C wrote:
>
https://codereview.chromium.org/2921453003/diff/40001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
> (right):
> 
>
https://codereview.chromium.org/2921453003/diff/40001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java:130:
> // to respond to the dialog next time.
> On 2017/06/01 20:50:50, dfalcantara wrote:
> > This could happen if the Activity dies now, I guess.
> 
> Done.
> 
>
https://codereview.chromium.org/2921453003/diff/40001/chrome/android/javatest...
> File
>
chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java
> (right):
> 
>
https://codereview.chromium.org/2921453003/diff/40001/chrome/android/javatest...
>
chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java:45:
> //                crbug.com/728297
> On 2017/06/01 20:50:50, dfalcantara wrote:
> > Does it make more sense to start up another suite for this because it's
> starting
> > an Activity?  This one just does measurements and things.
> 
> But creating the dialog requires an activity, you can't use it without one.  I
> don't know what that would accomplish.
> 
> The activity needs a context bound to it to inflate anything, so none of the
> setup would work in the dialog creation without it.

Bah, yeah forgot everything that happened in the first half.

lgtm

[Ted C, 2017-06-01 20:58:39]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-06-01 20:59:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 22:15:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496350719825930,
"parent_rev": "ae0d11211bae4d973474c10a26c40dc54cd97073", "commit_rev":
"4ca61512813b424e238dd5dc546d3f4b92991023"}

[commit-bot: I haz the power, 2017-06-01 22:15:39]

Description was changed from

==========
Ensure promo dialogs are dismissed when activities are destroyed.

BUG=727959
==========

to

==========
Ensure promo dialogs are dismissed when activities are destroyed.

BUG=727959

Review-Url: https://codereview.chromium.org/2921453003
Cr-Commit-Position: refs/heads/master@{#476452}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ca61512813b424e238dd5dc546d...
==========

[commit-bot: I haz the power, 2017-06-01 22:15:42]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4ca61512813b424e238dd5dc546d...