chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java - Issue 2921453003: Ensure promo dialogs are dismissed when activities are destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java

Issue 2921453003: Ensure promo dialogs are dismissed when activities are destroyed. (Closed)

Patch Set: Fix comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java

index 3b9244ef06a1b3663c0e8cf5f13d9b1a4009f158..144a7ba0decf7e51adc3f6cd935b543350369a1b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java

@@ -4,7 +4,7 @@

package org.chromium.chrome.browser.locale;

-import android.content.Context;

+import android.app.Activity;

import android.content.DialogInterface;

import android.content.Intent;

import android.os.Bundle;

@@ -68,9 +68,9 @@ public class SogouPromoDialog extends PromoDialog {

/**

* Creates an instance of the dialog.

- public SogouPromoDialog(

- Context context, LocaleManager localeManager, @Nullable Callback<Boolean> onDismissed) {

- super(context);

+ public SogouPromoDialog(Activity activity, LocaleManager localeManager,

+ @Nullable Callback<Boolean> onDismissed) {

+ super(activity);

mLocaleManager = localeManager;

setOnDismissListener(this);

setCanceledOnTouchOutside(false);