chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java - Issue 2921453003: Ensure promo dialogs are dismissed when activities are destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

Issue 2921453003: Ensure promo dialogs are dismissed when activities are destroyed. (Closed)

Patch Set: Fix comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialog.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

index 818e58e2d03a6ab9581386a3eaf24ac5f9a7f403..34ed5426dc7f2647b0d05931174a2d1bca2372a1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

@@ -5,7 +5,6 @@

package org.chromium.chrome.browser.preferences.datareduction;

import android.app.Activity;

-import android.content.Context;

import android.content.DialogInterface;

import android.view.View;

@@ -42,10 +41,10 @@ public class DataReductionPromoScreen extends PromoDialog {

/**

* DataReductionPromoScreen constructor.

- * @param context An Android context.

+ * @param activity An Android activity to display the dialog.

- public DataReductionPromoScreen(Context context) {

- super(context);

+ public DataReductionPromoScreen(Activity activity) {

+ super(activity);

mState = DataReductionProxyUma.ACTION_DISMISSED;

}