Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: src/inspector/v8-debugger-agent-impl.cc

Issue 2921373002: [inspector] Test how multiple sessions interact with pausing (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger.cc ('k') | test/inspector/sessions/debugger-stepping-and-breakpoints.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-agent-impl.cc
diff --git a/src/inspector/v8-debugger-agent-impl.cc b/src/inspector/v8-debugger-agent-impl.cc
index db71c5d8d3fc8fe4624012951711a0c785df5eb4..37c26e48801a40dbff88ae6c628fded8fc3355b0 100644
--- a/src/inspector/v8-debugger-agent-impl.cc
+++ b/src/inspector/v8-debugger-agent-impl.cc
@@ -286,6 +286,7 @@ void V8DebuggerAgentImpl::restore() {
Response V8DebuggerAgentImpl::setBreakpointsActive(bool active) {
if (!enabled()) return Response::Error(kDebuggerNotEnabled);
+ // TODO(dgozman): this state should be per-session, not global per debugger.
m_debugger->setBreakpointsActivated(active);
if (!active && !m_breakReason.empty()) {
clearBreakDetails();
@@ -1033,7 +1034,11 @@ V8DebuggerAgentImpl::currentAsyncStackTrace() {
m_debugger->maxAsyncCallChainDepth() - 1);
}
-bool V8DebuggerAgentImpl::isPaused() const { return m_debugger->isPaused(); }
+bool V8DebuggerAgentImpl::isPaused() const {
+ // TODO(dgozman): this check allows once context group to resume the other,
+ // since they share debugger.
+ return m_debugger->isPaused();
+}
void V8DebuggerAgentImpl::didParseSource(
std::unique_ptr<V8DebuggerScript> script, bool success) {
« no previous file with comments | « src/inspector/v8-debugger.cc ('k') | test/inspector/sessions/debugger-stepping-and-breakpoints.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698