Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: tools/perf/page_sets/key_silk_cases.py

Issue 2921333002: Explictly setting story names for rasterize_and_record_micro story sets (Closed)
Patch Set: Explictly setting story names for rasterize_and_record_micro story sets Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites_pages.py ('k') | tools/perf/page_sets/partial_invalidation_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_silk_cases.py
diff --git a/tools/perf/page_sets/key_silk_cases.py b/tools/perf/page_sets/key_silk_cases.py
index ee9395fba2f6506beefb25d044151d2989a01c5c..078915c00047db783dfbb04dadc8209596b367ba 100644
--- a/tools/perf/page_sets/key_silk_cases.py
+++ b/tools/perf/page_sets/key_silk_cases.py
@@ -15,9 +15,13 @@ class KeySilkCasesPage(page_module.Page):
run_no_page_interactions: whether the page will run any interactions after
navigate steps.
"""
+ name = url
+ if not name.startswith('http'):
+ name = url.split('/')[-1]
super(KeySilkCasesPage, self).__init__(
url=url, page_set=page_set, credentials_path = 'data/credentials.json',
- shared_page_state_class=shared_page_state.SharedMobilePageState)
+ shared_page_state_class=shared_page_state.SharedMobilePageState,
+ name=name)
self.archive_data_file = 'data/key_silk_cases.json'
self._run_no_page_interactions = run_no_page_interactions
@@ -723,7 +727,8 @@ class KeySilkCasesPageSet(story.StorySet):
def __init__(self, run_no_page_interactions=False):
super(KeySilkCasesPageSet, self).__init__(
archive_data_file='data/key_silk_cases.json',
- cloud_storage_bucket=story.PARTNER_BUCKET)
+ cloud_storage_bucket=story.PARTNER_BUCKET,
+ verify_names=True)
self.AddStory(Page1(self, run_no_page_interactions))
self.AddStory(Page2(self, run_no_page_interactions))
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites_pages.py ('k') | tools/perf/page_sets/partial_invalidation_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698