Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issue 2921063002: Clean up CRWSessionController usage in TabTest and TabModelTest. (Closed)

Created:
3 years, 6 months ago by kkhorimoto
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up CRWSessionController usage in TabTest and TabModelTest. This CL updates these tests to use NavigationManagerImpl:: CommitPendingItem() and cleans up DEPS for old inclusions. BUG=454984 Review-Url: https://codereview.chromium.org/2921063002 Cr-Commit-Position: refs/heads/master@{#476833} Committed: https://chromium.googlesource.com/chromium/src/+/aeb794edec6b772d81a0f531e29264daee5f3f9a

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M ios/chrome/browser/tabs/DEPS View 2 chunks +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_unittest.mm View 4 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 2 chunks +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
kkhorimoto
rebase
3 years, 6 months ago (2017-06-02 18:39:54 UTC) #1
kkhorimoto
3 years, 6 months ago (2017-06-02 18:40:14 UTC) #3
Eugene But (OOO till 7-30)
lgtm
3 years, 6 months ago (2017-06-02 21:50:56 UTC) #4
kkhorimoto
rebase
3 years, 6 months ago (2017-06-02 22:05:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921063002/40001
3 years, 6 months ago (2017-06-02 22:39:35 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 23:26:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aeb794edec6b772d81a0f531e292...

Powered by Google App Engine
This is Rietveld 408576698