Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: ios/chrome/browser/tabs/tab_model_unittest.mm

Issue 2921063002: Clean up CRWSessionController usage in TabTest and TabModelTest. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/DEPS ('k') | ios/chrome/browser/tabs/tab_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm
index 9857518413c0607426a363777c53437d508c4acf..e1131973277c9d605c2a112099c939b39f67ba2b 100644
--- a/ios/chrome/browser/tabs/tab_model_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm
@@ -25,7 +25,6 @@
#import "ios/chrome/browser/web/chrome_web_client.h"
#import "ios/chrome/browser/web_state_list/web_state_list.h"
#include "ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_state_manager.h"
-#import "ios/web/navigation/crw_session_controller.h"
#import "ios/web/navigation/navigation_manager_impl.h"
#import "ios/web/public/crw_session_storage.h"
#import "ios/web/public/navigation_manager.h"
@@ -846,7 +845,7 @@ void SetTabModel(TabModel* tab_model) {
inBackground:NO];
// Force the history to update, as it is used to determine grouping.
ASSERT_TRUE([parent navigationManagerImpl]);
- [[parent navigationManagerImpl]->GetSessionController() commitPendingItem];
+ [parent navigationManagerImpl]->CommitPendingItem();
[tab_model_ insertTabWithURL:GURL(kURL1)
referrer:web::Referrer()
transition:ui::PAGE_TRANSITION_TYPED
@@ -894,7 +893,7 @@ void SetTabModel(TabModel* tab_model) {
parent_params.transition_type = ui::PAGE_TRANSITION_TYPED;
[parent navigationManager]->LoadURLWithParams(parent_params);
ASSERT_TRUE([parent navigationManagerImpl]);
- [[parent navigationManagerImpl]->GetSessionController() commitPendingItem];
+ [parent navigationManagerImpl]->CommitPendingItem();
EXPECT_EQ([tab_model_ indexOfTab:parent], 0U);
// Add a new tab. It should be added behind the parent. It should not be added
@@ -947,7 +946,7 @@ void SetTabModel(TabModel* tab_model) {
inBackground:NO];
// Force the history to update, as it is used to determine grouping.
ASSERT_TRUE([parent navigationManagerImpl]);
- [[parent navigationManagerImpl]->GetSessionController() commitPendingItem];
+ [parent navigationManagerImpl]->CommitPendingItem();
[tab_model_ insertTabWithURL:GURL(kURL1)
referrer:web::Referrer()
transition:ui::PAGE_TRANSITION_TYPED
« no previous file with comments | « ios/chrome/browser/tabs/DEPS ('k') | ios/chrome/browser/tabs/tab_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698