Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js

Issue 2921053002: [Devtools] Removed "redirects" from NetworkRequest to use redirectSource (Closed)
Patch Set: Merge branch 'MOVE_NETWORK_STUFF_AROUND' into REMOVE_REDIRECTS_REBASE Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js b/third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js
index 9c32457bdbbd6d3033222d9ad8f563a7289a61e1..b9650660880c5289d507a54e476af9ad49bf16f8 100644
--- a/third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js
+++ b/third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js
@@ -177,9 +177,10 @@ NetworkLog.NetworkLog = class extends Common.Object {
var scriptId = null;
var initiator = request.initiator();
- if (request.redirectSource) {
+ var redirectSource = request.redirectSource();
+ if (redirectSource) {
type = SDK.NetworkRequest.InitiatorType.Redirect;
- url = request.redirectSource.url();
+ url = redirectSource.url();
} else if (initiator) {
if (initiator.type === Protocol.Network.InitiatorType.Parser) {
type = SDK.NetworkRequest.InitiatorType.Parser;
@@ -300,8 +301,11 @@ NetworkLog.NetworkLog = class extends Common.Object {
continue;
if (!currentPageLoad) {
currentPageLoad = new NetworkLog.PageLoad(request);
- if (request.redirects)
- requestsToAdd.pushAll(request.redirects);
+ var redirectSource = request.redirectSource();
+ while (redirectSource) {
+ requestsToAdd.push(redirectSource);
+ redirectSource = redirectSource.redirectSource();
+ }
}
requestsToAdd.push(request);
}

Powered by Google App Engine
This is Rietveld 408576698