Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc

Issue 2920873002: Ensure that BidirectionalStreamQuicImpl does not synchronously invoke callbacks (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/bidirectional_stream_quic_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc b/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
index bd81ec3d09613d778a2f494793e0163c30e62cc9..2ea276e2b95bf7ef6f98571e9631972eb733499d 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
+++ b/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
@@ -163,12 +163,18 @@ class TestDelegateBase : public BidirectionalStreamImpl::Delegate {
void Start(const BidirectionalStreamRequestInfo* request_info,
const NetLogWithSource& net_log,
std::unique_ptr<QuicChromiumClientSession::Handle> session) {
+ not_expect_callback_ = true;
stream_ = base::MakeUnique<BidirectionalStreamQuicImpl>(std::move(session));
stream_->Start(request_info, net_log, send_request_headers_automatically_,
this, nullptr);
+ not_expect_callback_ = false;
}
- void SendRequestHeaders() { stream_->SendRequestHeaders(); }
+ void SendRequestHeaders() {
+ not_expect_callback_ = true;
+ stream_->SendRequestHeaders();
+ not_expect_callback_ = false;
+ }
void SendData(const scoped_refptr<IOBuffer>& data,
int length,
« no previous file with comments | « net/quic/chromium/bidirectional_stream_quic_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698