Enable Home Page tile by default for Chrome Home.

Enable Home Page tile by default for Chrome Home.

Only CrHome is implementing this feature and requires it to be enabled
by default.

In order to disable it on demand for other platforms, the feature is not
deleted (yet).

BUG=703994
Review-Url: https://codereview.chromium.org/2920773002
Cr-Commit-Position: refs/heads/master@{#476300}
Committed: https://chromium.googlesource.com/chromium/src/+/f770fd9f1d7bb27e3f1ae9aeb57075cdc024d161

[fhorschig, 2017-06-01 12:21:23]

fhorschig@chromium.org changed reviewers:
+ sfiera@chromium.org

[fhorschig, 2017-06-01 12:21:23]

Hi Chris,
would you please take a look at this one-liner?

(As discussed with kingston, this feature will 
be tied to Chrome Home.)

[fhorschig, 2017-06-01 12:21:28]

The CQ bit was checked by fhorschig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 12:21:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2017-06-01 12:27:00]

I don't see how this is restricted to Chrome Home.

[fhorschig, 2017-06-01 12:39:34]

On 2017/06/01 12:27:00, sfiera wrote:
> I don't see how this is restricted to Chrome Home.

Basically, every platform either implements the HomePageClient or uses a
nullptr.
So far, every platform uses nullptr except Android.
And for Android, I guard the creation depending on CrHome another CL (that just
landed):
https://chromium.googlesource.com/chromium/src/+/3fc1f818eaab417801a21886ce9c...

We could argue about removing the Feature altogether.
But it is likely that we need it for other platforms 
(e.g. iOS, local Desktop NTP) and want to Finch-control
the same feature for different platforms.

[sfiera, 2017-06-01 12:58:14]

OK, I didn't see the other CL.

I'd rather drop the feature for now. We have a lot of them already, and having a
feature that is implemented on Android (but not used there) while keeping it
around for other platforms (where it isn't implemented) is confusing. When
another platform adds an implementation, they can add a feature to go with it.

[commit-bot: I haz the power, 2017-06-01 13:14:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 13:14:31]

Dry run: This issue passed the CQ dry run.

[fhorschig, 2017-06-01 13:32:44]

On 2017/06/01 12:58:14, sfiera wrote:
> OK, I didn't see the other CL.
> 
> I'd rather drop the feature for now. We have a lot of them already, and having
a
> feature that is implemented on Android (but not used there) while keeping it
> around for other platforms (where it isn't implemented) is confusing. When
> another platform adds an implementation, they can add a feature to go with it.

Fair enough, here you go.

[sfiera, 2017-06-01 13:48:52]

Thanks! LGTM

[fhorschig, 2017-06-01 14:12:17]

The CQ bit was checked by fhorschig@chromium.org

[commit-bot: I haz the power, 2017-06-01 14:12:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 15:51:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496326337157650,
"parent_rev": "09a769b10b54536d1b4ba1c68c288f0f87203c12", "commit_rev":
"f770fd9f1d7bb27e3f1ae9aeb57075cdc024d161"}

[commit-bot: I haz the power, 2017-06-01 15:51:32]

Description was changed from

==========
Enable Home Page tile by default for Chrome Home.

Only CrHome is implementing this feature and requires it to be enabled
by default.

In order to disable it on demand for other platforms, the feature is not
deleted (yet).

BUG=703994
==========

to

==========
Enable Home Page tile by default for Chrome Home.

Only CrHome is implementing this feature and requires it to be enabled
by default.

In order to disable it on demand for other platforms, the feature is not
deleted (yet).

BUG=703994

Review-Url: https://codereview.chromium.org/2920773002
Cr-Commit-Position: refs/heads/master@{#476300}
Committed:
https://chromium.googlesource.com/chromium/src/+/f770fd9f1d7bb27e3f1ae9aeb570...
==========

[commit-bot: I haz the power, 2017-06-01 15:51:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f770fd9f1d7bb27e3f1ae9aeb570...