Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: components/ntp_tiles/constants.h

Issue 2920773002: Enable Home Page tile by default for Chrome Home. (Closed)
Patch Set: Remove feature constant completely Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/ntp_tiles/constants.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_TILES_CONSTANTS_H_ 5 #ifndef COMPONENTS_NTP_TILES_CONSTANTS_H_
6 #define COMPONENTS_NTP_TILES_CONSTANTS_H_ 6 #define COMPONENTS_NTP_TILES_CONSTANTS_H_
7 7
8 namespace base { 8 namespace base {
9 struct Feature; 9 struct Feature;
10 } // namespace base 10 } // namespace base
11 11
12 namespace ntp_tiles { 12 namespace ntp_tiles {
13 13
14 // Name of the field trial to configure PopularSites. 14 // Name of the field trial to configure PopularSites.
15 extern const char kPopularSitesFieldTrialName[]; 15 extern const char kPopularSitesFieldTrialName[];
16 16
17 // This feature is enabled by default. Otherwise, users who need it would not 17 // This feature is enabled by default. Otherwise, users who need it would not
18 // get the right configuration timely enough. The configuration affects only 18 // get the right configuration timely enough. The configuration affects only
19 // Android or iOS users. 19 // Android or iOS users.
20 extern const base::Feature kPopularSitesBakedInContentFeature; 20 extern const base::Feature kPopularSitesBakedInContentFeature;
21 21
22 // Feature to allow the new Google favicon server for fetching favicons for Most 22 // Feature to allow the new Google favicon server for fetching favicons for Most
23 // Likely tiles on the New Tab Page. 23 // Likely tiles on the New Tab Page.
24 extern const base::Feature kNtpMostLikelyFaviconsFromServerFeature; 24 extern const base::Feature kNtpMostLikelyFaviconsFromServerFeature;
25 25
26 // Feature to pin any set home page as first tile.
27 extern const base::Feature kPinHomePageAsTileFeature;
28
29 // Use this to find out whether the kNtpMostLikelyFaviconsFromServerFeature is 26 // Use this to find out whether the kNtpMostLikelyFaviconsFromServerFeature is
30 // enabled. This helper function abstracts iOS special way to override the 27 // enabled. This helper function abstracts iOS special way to override the
31 // feature (via command-line params). 28 // feature (via command-line params).
32 // TODO(jkrcal): Remove once crbug.com/718926 is fixed. 29 // TODO(jkrcal): Remove once crbug.com/718926 is fixed.
33 bool AreNtpMostLikelyFaviconsFromServerEnabled(); 30 bool AreNtpMostLikelyFaviconsFromServerEnabled();
34 31
35 } // namespace ntp_tiles 32 } // namespace ntp_tiles
36 33
37 #endif // COMPONENTS_NTP_TILES_CONSTANTS_H_ 34 #endif // COMPONENTS_NTP_TILES_CONSTANTS_H_
OLDNEW
« no previous file with comments | « no previous file | components/ntp_tiles/constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698