components/ntp_tiles/most_visited_sites.cc - Issue 2920773002: Enable Home Page tile by default for Chrome Home.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/most_visited_sites.cc

Issue 2920773002: Enable Home Page tile by default for Chrome Home. (Closed)

Patch Set: Remove feature constant completely Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/most_visited_sites.cc

diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc

index 81fe916f97cc8630a5f1c5b0c018cff7b77c8fe4..f0307c609a9123980b16e8905045e360e7d80d06 100644

--- a/components/ntp_tiles/most_visited_sites.cc

+++ b/components/ntp_tiles/most_visited_sites.cc

@@ -479,8 +479,7 @@ void MostVisitedSites::TopSitesChanged(TopSites* top_sites,

}

bool MostVisitedSites::ShouldAddHomeTile() const {

- return base::FeatureList::IsEnabled(kPinHomePageAsTileFeature) &&

- num_sites_ > 0u &&

+ return num_sites_ > 0u &&

home_page_client_ && // No platform-specific implementation - no tile.

home_page_client_->IsHomePageEnabled() &&

!home_page_client_->IsNewTabPageUsedAsHomePage() &&