Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2919893002:
[MD Settings] Add ARIA roles to profile image chooser for ChromeVox. (Closed)
|
Created:
3 years, 6 months ago by quacht Modified:
3 years, 6 months ago Reviewers:
hcarmona CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD Settings] Add ARIA roles to profile image chooser for ChromeVox.
Add ARIA roles to profile image chooser for ChromeVox. User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the ARIA role of a radio group, whereas previously, the icon was not selectable.
BUG=709573
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2919893002
Cr-Commit-Position: refs/heads/master@{#478330}
Committed: https://chromium.googlesource.com/chromium/src/+/8ac19bc61e0e1f2d500f2313ddac1a916e1c0e83
Patch Set 1 #
Total comments: 1
Patch Set 2 : Remove space at end of line. #Messages
Total messages: 19 (14 generated)
Description was changed from ========== select camera icon with ChromeVox User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the aria role of a radio group, whereas previously, the icon was not selectable. Merge branch 'master' of https://chromium.googlesource.com/chromium/src into chrome-os chrome os build and launch scripts BUG=709573 ========== to ========== select camera icon with ChromeVox User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the aria role of a radio group, whereas previously, the icon was not selectable. Merge branch 'master' of https://chromium.googlesource.com/chromium/src into chrome-os chrome os build and launch scripts BUG=709573 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by quacht@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== select camera icon with ChromeVox User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the aria role of a radio group, whereas previously, the icon was not selectable. Merge branch 'master' of https://chromium.googlesource.com/chromium/src into chrome-os chrome os build and launch scripts BUG=709573 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Settings] Select camera icon with ChromeVox User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the aria role of a radio group, whereas previously, the icon was not selectable. Merge branch 'master' of https://chromium.googlesource.com/chromium/src into chrome-os chrome os build and launch scripts BUG=709573 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
quacht@google.com changed reviewers: + hcarmona@google.com
quacht@google.com changed reviewers: + hcarmona@chromium.org - hcarmona@google.com
A few comments on description:
- The first line should match the subject
- The first line should be more descriptive of what you did
consider:
Add ARIA roles to profile image chooser for ChromeVox.
- You can remove any local commit comments
- Expanding more (like you did) is good
https://codereview.chromium.org/2919893002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/change_picture.html (right):
https://codereview.chromium.org/2919893002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/change_picture.html:114: <img
id="oldImage" data-type$="[[selectionTypesEnum_.OLD]]"
nit: remove space at end of line
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [MD Settings] Select camera icon with ChromeVox User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the aria role of a radio group, whereas previously, the icon was not selectable. Merge branch 'master' of https://chromium.googlesource.com/chromium/src into chrome-os chrome os build and launch scripts BUG=709573 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Settings] Add ARIA roles to profile image chooser for ChromeVox. Add ARIA roles to profile image chooser for ChromeVox. User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the ARIA role of a radio group, whereas previously, the icon was not selectable. BUG=709573 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by quacht@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/06/02 00:50:04, hcarmona wrote: > A few comments on description: > > - The first line should match the subject > - The first line should be more descriptive of what you did > consider: > Add ARIA roles to profile image chooser for ChromeVox. > - You can remove any local commit comments > - Expanding more (like you did) is good > > https://codereview.chromium.org/2919893002/diff/1/chrome/browser/resources/se... > File chrome/browser/resources/settings/people_page/change_picture.html (right): > > https://codereview.chromium.org/2919893002/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/people_page/change_picture.html:114: <img > id="oldImage" data-type$="[[selectionTypesEnum_.OLD]]" > nit: remove space at end of line ptal
LGTM
The CQ bit was checked by quacht@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497026149901930,
"parent_rev": "4713edd911eb7a037368cca7737cadd3f6859653", "commit_rev":
"8ac19bc61e0e1f2d500f2313ddac1a916e1c0e83"}
Message was sent while issue was closed.
Description was changed from ========== [MD Settings] Add ARIA roles to profile image chooser for ChromeVox. Add ARIA roles to profile image chooser for ChromeVox. User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the ARIA role of a radio group, whereas previously, the icon was not selectable. BUG=709573 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Settings] Add ARIA roles to profile image chooser for ChromeVox. Add ARIA roles to profile image chooser for ChromeVox. User using ChromeVox can now jump to the camera icon by jumping to the next/previous form (Search + F). User can select the icon currently focused with ChromeVox by pressing Search + space. The icon selector now has the ARIA role of a radio group, whereas previously, the icon was not selectable. BUG=709573 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2919893002 Cr-Commit-Position: refs/heads/master@{#478330} Committed: https://chromium.googlesource.com/chromium/src/+/8ac19bc61e0e1f2d500f2313ddac... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8ac19bc61e0e1f2d500f2313ddac... |
