Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2993)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.html

Issue 2919893002: [MD Settings] Add ARIA roles to profile image chooser for ChromeVox. (Closed)
Patch Set: Remove space at end of line. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/change_picture.html
diff --git a/chrome/browser/resources/settings/people_page/change_picture.html b/chrome/browser/resources/settings/people_page/change_picture.html
index 963de294a34680c7d5c7a4f74d6e6c1baf7db5a2..377f9cc7178cbabfda8af76f86bf4659b0667c9c 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.html
+++ b/chrome/browser/resources/settings/people_page/change_picture.html
@@ -99,23 +99,23 @@
</iron-a11y-keys>
<div id="availableIcons" class="start">
<iron-selector id="selector" on-iron-activate="onImageActivate_"
- selected-item="{{selectedItem_}}">
- <iron-icon id="cameraImage"
+ selected-item="{{selectedItem_}}" role="radiogroup">
+ <iron-icon id="cameraImage" role="radio"
data-type$="[[selectionTypesEnum_.CAMERA]]"
icon="settings:camera-alt" title="$i18n{takePhoto}"
hidden="[[!cameraPresent_]]">
</iron-icon>
- <iron-icon data-type$="[[selectionTypesEnum_.FILE]]"
+ <iron-icon data-type$="[[selectionTypesEnum_.FILE]]" role="radio"
icon="cr:folder" title="$i18n{chooseFile}">
</iron-icon>
- <img id="profileImage"
+ <img id="profileImage" role="radio"
data-type$="[[selectionTypesEnum_.PROFILE]]"
src="[[profileImageUrl_]]" title="$i18n{profilePhotoLoading}">
<img id="oldImage" data-type$="[[selectionTypesEnum_.OLD]]"
- src="[[oldImageUrl_]]" hidden="[[!oldImageUrl_]]"
+ role="radio" src="[[oldImageUrl_]]" hidden="[[!oldImageUrl_]]"
title="$i18n{oldPhoto}">
<template is="dom-repeat" items="[[defaultImages_]]">
- <img data-type$="[[selectionTypesEnum_.DEFAULT]]"
+ <img data-type$="[[selectionTypesEnum_.DEFAULT]]" role="radio"
data-default-image-index$="[[index]]" src="[[item.url]]"
title="[[item.title]]">
</template>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698